(Issue #277) Make CXXGraph MSVC-Compatible

[nrkramer]

In this PR, we're switching out calls to srand and rand_r (in which rand_r is a Unix-only function included in <stdlib.h>), with usages of std::random constructs.

These constructs are initialized in a thread-safe manner using TLS:

  thread_local static std::default_random_engine rand;
  thread_local static std::uniform_int_distribution distribution(0, RAND_MAX);

  rand.seed(some_seed);
  distribution(rand); // Computes the next random number in the sequence.

The reason we use TLS is to pay the initialization cost only once per-thread. This ensures thread-safety of the PRNG sequence, as well as providing a decent tradeoff between performance and memory.

• A reference to a related issue in your repository.
  • Make CXXGraph MSVC-Compatible #277
• A description of the changes proposed in the pull request.
  • Switch usages of srand and rand_r to the more cross-platform <random> implementations.
  • Remove 2 test asserts that relied on comparisons of platform-dependent hashing implementations.
• @mentions of the person or team responsible for reviewing proposed changes. ( optional )
  • @ZigRazor

[ghost]

👇 Click on the image for a new way to code review

Legend