Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CXXGraph MSVC-Compatible #277

Closed
nrkramer opened this issue May 6, 2023 · 3 comments · Fixed by #280
Closed

Make CXXGraph MSVC-Compatible #277

nrkramer opened this issue May 6, 2023 · 3 comments · Fixed by #280
Labels
development Development of new Functionalities enhancement New feature or request Priority:Medium Priority Label for medium priority issue

Comments

@nrkramer
Copy link
Collaborator

nrkramer commented May 6, 2023 •
edited
Loading

Currently, the library relies on some Unix stdlib functionality (namely, rand_r)

To make the library more portable, alternative functions and C++ functionality should be added to make sure MSVC users can compile. This will go a long way to ensuring portability as well.

We can start by replacing rand_r with a PRNG from <random>
@nrkramer nrkramer mentioned this issue May 6, 2023
Merged
@nrkramer
Copy link
Collaborator Author

nrkramer commented May 6, 2023

I'll open a PR for this once #276 is merged

@ZigRazor
Copy link
Owner

ZigRazor commented May 7, 2023

ok #276 is merged

@ZigRazor ZigRazor added enhancement New feature or request development Development of new Functionalities Priority:Medium Priority Label for medium priority issue labels May 7, 2023
@nrkramer nrkramer mentioned this issue May 7, 2023
Merged
@nrkramer
Copy link
Collaborator Author

nrkramer commented May 7, 2023

Opened #280

@ZigRazor ZigRazor linked a pull request May 8, 2023 that will close this issue
(Issue #277) Make CXXGraph MSVC-Compatible #280
Merged
ZigRazor pushed a commit that referenced this issue May 8, 2023
@nrkramer
(Issue #277) Make CXXGraph MSVC-Compatible (#280)
04c6cb7 
* Get building with MSVC

* Run .clangformat

* Fix benchmarking builds

* Cleanup

* More cleanup. Remove openSSL entirely from project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
development Development of new Functionalities enhancement New feature or request Priority:Medium Priority Label for medium priority issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(Issue #277) Make CXXGraph MSVC-Compatible nrkramer/CXXGraph
2 participants
@nrkramer @ZigRazor