Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getting started guide #423

Merged
merged 4 commits into from
May 2, 2024
Merged

Add getting started guide #423

merged 4 commits into from
May 2, 2024

Conversation

ghost
Copy link

@ghost ghost commented Apr 30, 2024

Related to #407.

Adds additional documentation to the Docusaurus site that supplements the existing 'How to Use' document and adds in a getting started guide. Revised PR.

Comment on lines 8 to 16

```
include "CXXGraph.hpp"

using namespace CXXGRAPH;
```

It's that easy!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, not yet! We haven't created a deployment/combined header that can be simply included into a project. I think @ZigRazor is tracking some work to add that.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is true after the installation, @nolankramer can you open an issue to track this missing, or almost misconfigured, installation phase in cmake?
Thank you in advance, I think in any case that this pull request can be merged, you agree?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have opened the new Issue

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we update the instructions here to specify using CPM (which I use in my own project), this should be mergeable.

For now, using CPM looks like this:

CPMAddPackage("gh:ZigRazor/CXXGraph")
if (CXXGraph_ADDED)
    add_library(CXXGraph INTERFACE IMPORTED GLOBAL)
    target_include_directories(CXXGraph INTERFACE "${CXXGraph_SOURCE_DIR}/include")
endif()

Copy link
Author

@ghost ghost Apr 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a section with this!

include "CXXGraph.hpp"

using namespace CXXGRAPH;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using namespace CXXGRAPH; -> using namespace CXXGraph;

Comment on lines 30 to 31
CXXGRAPH::Node<int> node1("1", 1);
CXXGRAPH::Node<int> node2("2", 2);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CXXGRAPH::Node<int> node1("1", 1);
CXXGRAPH::Node<int> node2("2", 2);

Should be

CXXGraph::Node<int> node1("1", 1);
CXXGraph::Node<int> node2("2", 2);

All the references below should change CXXGRAPH -> CXXGraph

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is true, @Horicabu can you correct these?

@ghost
Copy link
Author

ghost commented Apr 30, 2024

I can gladly correct the code samples!

@ZigRazor
Copy link
Owner

ZigRazor commented May 2, 2024

Good Job I merge it!

@ZigRazor ZigRazor merged commit 4598944 into ZigRazor:WebSite May 2, 2024
1 of 3 checks passed
@ZigRazor
Copy link
Owner

ZigRazor commented May 2, 2024

@Horicabu after deploy I noticed that there is no possibility to access the making a Graph page from the left side menù.
Can you add also this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants