-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests & Thread safe dijkstra #93
Conversation
Changes to your CodeSee Architecture Map:View this PR diagram as an interactive map View more CodeSee Maps Legend |
Codecov Report
@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 95.76% 95.80% +0.03%
==========================================
Files 36 36
Lines 3593 3623 +30
==========================================
+ Hits 3441 3471 +30
Misses 152 152
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@sidml i think it is the right approch, in any case the graph is locked so no critical sections can be touched |
This PR should now also address issues:
@ZigRazor Please review & merge. |
@ZigRazor
Should partially address concerns raised in #88
As discussed earlier, the trick is to explicitly use Graph implementation instead of Graph_TS for functions like getNodeSet, getAdjMatrix. I have made changes for dijkstra's algorithm right now.
If this approach is okay, I will make changes in other algorithms as well.