Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests & Thread safe dijkstra #93

Merged
merged 5 commits into from
Oct 15, 2021
Merged

Tests & Thread safe dijkstra #93

merged 5 commits into from
Oct 15, 2021

Conversation

sidml
Copy link
Contributor

@sidml sidml commented Oct 14, 2021

@ZigRazor
Should partially address concerns raised in #88
As discussed earlier, the trick is to explicitly use Graph implementation instead of Graph_TS for functions like getNodeSet, getAdjMatrix. I have made changes for dijkstra's algorithm right now.
If this approach is okay, I will make changes in other algorithms as well.

@github-actions github-actions bot added core something about core test Something about test labels Oct 14, 2021
@ghost
Copy link

ghost commented Oct 14, 2021

Changes to your CodeSee Architecture Map:

View a CodeSee Map of these changes

View this PR diagram as an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

@codecov-commenter
Copy link

Codecov Report

Merging #93 (6b9b83a) into master (e95bdc8) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   95.76%   95.80%   +0.03%     
==========================================
  Files          36       36              
  Lines        3593     3623      +30     
==========================================
+ Hits         3441     3471      +30     
  Misses        152      152              
Flag Coverage Δ
unittests 95.80% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
include/Graph/Graph.hpp 97.67% <100.00%> (ø)
test/DijkstraTest.cpp 100.00% <100.00%> (ø)
include/Partitioning/HDRF.hpp 71.26% <0.00%> (-5.75%) ⬇️
include/Graph/Graph_TS.hpp 27.17% <0.00%> (+5.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e95bdc8...6b9b83a. Read the comment docs.

@ZigRazor
Copy link
Owner

@sidml i think it is the right approch, in any case the graph is locked so no critical sections can be touched

@ZigRazor ZigRazor added development Development of new Functionalities enhancement New feature or request hacktoberfest hacktoberfest issue labels Oct 14, 2021
@sidml
Copy link
Contributor Author

sidml commented Oct 15, 2021

This PR should now also address issues:

@ZigRazor Please review & merge.

@sidml sidml marked this pull request as ready for review October 15, 2021 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core something about core development Development of new Functionalities enhancement New feature or request hacktoberfest hacktoberfest issue test Something about test
Projects
None yet
3 participants