Charge gas for failed transaction (#3659)

Co-authored-by: bzawisto <bartosz@zilliqa.com>
Zilliqa · Jun 13, 2023 · 8e8d37e · 8e8d37e
1 parent aa38673
commit 8e8d37e
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 2 deletions.
diff --git a/src/libCps/CpsExecutor.cpp b/src/libCps/CpsExecutor.cpp
@@ -170,6 +170,18 @@ CpsExecuteResult CpsExecutor::RunFromScilla(
 
   // Increase nonce regardless of processing result
   mAccountStore.IncreaseNonceForAccount(cpsCtx.origSender);
+  // Deduct from account balance gas used for failed transaction
+  if (isFailure) {
+    const auto usedGasCore = clientContext.gasLimit - gasRemainedCore;
+    uint128_t gasCost;
+    // Convert here because we deducted in eth units.
+    if (!SafeMath<uint128_t>::mul(usedGasCore, clientContext.gasPrice,
+                                  gasCost)) {
+      return {TxnStatus::ERROR, false, {}};
+    }
+    const auto amount = Amount::fromQa(gasCost);
+    mAccountStore.DecreaseBalance(cpsCtx.origSender, amount);
+  }
   return execResult;
 }