Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Charge gas for failed transaction #3659

Merged
merged 1 commit into from Jun 13, 2023

Conversation

bzawisto
Copy link
Contributor

Description

Gas should be charged for failed transaction too.

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test

@github-actions github-actions bot changed the title Charge gas for failed transaction [master] Charge gas for failed transaction Jun 13, 2023
@github-actions github-actions bot added this to PRs in development in Core Jun 13, 2023
Core automation moved this from PRs in development to PRs approved - ready to merge! Jun 13, 2023
@bzawisto bzawisto merged commit 8e8d37e into master Jun 13, 2023
5 checks passed
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Jun 13, 2023
@bzawisto bzawisto deleted the ZIL-5265-Gas-is-not-being-deducted-for-failed-txn branch June 13, 2023 09:24
bzawisto added a commit that referenced this pull request Jun 13, 2023
Co-authored-by: bzawisto <bartosz@zilliqa.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Core
  
PRs done (merged)
Development

Successfully merging this pull request may close these issues.

None yet

2 participants