Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clang and memory sanitizer support #1473

Closed
wants to merge 6 commits into from
Closed

Add Clang and memory sanitizer support #1473

wants to merge 6 commits into from

Conversation

bb111189
Copy link
Contributor

@bb111189 bb111189 commented Feb 22, 2019

Description

Add support for Clang (7.0.1) and memory sanitizer (with origin tracking level 2)

Other fixes:

  • Typos in log file. requried -> required

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test (gcc/g++)
  • local machine test (clang)
  • local machine test (gcc/g++) - Cuda
  • local machine test (clang) - Cuda
  • small-scale cloud test

@bb111189 bb111189 added in-progress Untested Haven't been tested yet labels Feb 22, 2019
@bb111189 bb111189 self-assigned this Feb 22, 2019
@codecov-io
Copy link

codecov-io commented Feb 22, 2019

Codecov Report

Merging #1473 into master will decrease coverage by 0.49%.
The diff coverage is 60%.

@@            Coverage Diff            @@
##           master    #1473     +/-   ##
=========================================
- Coverage   30.73%   30.24%   -0.5%     
=========================================
  Files         256      249      -7     
  Lines       29954    29653    -301     
=========================================
- Hits         9207     8969    -238     
+ Misses      20747    20684     -63
Impacted Files Coverage Δ
src/libNode/ViewChangeBlockProcessing.cpp 0% <0%> (ø) ⬆️
src/libCrypto/PrivKey.cpp 59.25% <100%> (ø) ⬆️
src/libCrypto/Schnorr.cpp 72.19% <100%> (ø) ⬆️
src/libCrypto/MultiSig.cpp 64.05% <100%> (ø) ⬆️
src/libData/BlockChainData/BlockLinkChain.h 0% <0%> (-100%) ⬇️
src/libData/BlockChainData/BlockChain.h 0% <0%> (-92.31%) ⬇️
src/libData/BlockChainData/BlockLinkChain.cpp 0% <0%> (-85.46%) ⬇️
src/libData/DataStructures/CircularArray.h 96.77% <0%> (-3.23%) ⬇️
src/libPersistence/BlockStorage.cpp 31.68% <0%> (-2.39%) ⬇️
src/libMessage/Messenger.cpp 29.41% <0%> (-0.67%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de9741a...a86105b. Read the comment docs.

@bb111189 bb111189 requested a review from Gnnng March 13, 2019 04:16
@bb111189
Copy link
Contributor Author

obselete PR

@bb111189 bb111189 closed this Dec 16, 2019
@n-hutton n-hutton deleted the build/clang branch August 8, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in-progress Untested Haven't been tested yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants