Add retry mechanism for send pow to proxy #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1683 +/- ##
==========================================
+ Coverage 33.57% 33.58% +<.01%
==========================================
Files 270 270
Lines 32991 33002 +11
==========================================
+ Hits 11078 11083 +5
- Misses 21913 21919 +6
Continue to review full report at Codecov.
|
ansnunez
reviewed
Jun 11, 2019
src/libPOW/pow.cpp
Outdated
| @@ -387,7 +387,20 @@ ethash_mining_result_t POW::RemoteMine(const PairOfKey& pairOfKey, | |||
| m_shouldMine = true; | |||
|
|
|||
| ethash_mining_result_t miningResult{"", "", 0, false}; | |||
| if (!SendWorkToProxy(pairOfKey, blockNum, headerHash, boundary, timeWindow)) { | |||
| const int MAX_RETRY_SEND_TIME = 5; | |||
There was a problem hiding this comment.
Should we move this to constants.xml?
ShengguangXiao
force-pushed
the
fix/retry_send_pow
branch
from
a31393d
to
25dceba
Compare
ansnunez
approved these changes
Jun 11, 2019
bb111189
approved these changes
Jun 11, 2019
ShengguangXiao
force-pushed
the
fix/retry_send_pow
branch
from
3c882e2
to
41effdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some times because network issue, the pow request failed to send to proxy, have a retry mechanism will have more chance to success.
#1681
Backward Compatibility
Review Suggestion
Status
Implementation
Integration Test (Core Team)