Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checksum check #1738

Merged
merged 1 commit into from
Jul 29, 2019
Merged

Add checksum check #1738

merged 1 commit into from
Jul 29, 2019

Conversation

sandipbhoir
Copy link
Contributor

Description

https://github.com/Zilliqa/Issues/issues/553

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test

@sandipbhoir sandipbhoir added the feature request Requesting new features label Jul 26, 2019
@sandipbhoir sandipbhoir requested review from Gnnng and ckyang July 26, 2019 05:56
@sandipbhoir sandipbhoir self-assigned this Jul 26, 2019
@sandipbhoir sandipbhoir added the Ready Ready for review label Jul 26, 2019
@codecov-io
Copy link

codecov-io commented Jul 26, 2019

Codecov Report

Merging #1738 into master will decrease coverage by 1.69%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #1738     +/-   ##
=========================================
- Coverage   33.55%   31.85%   -1.7%     
=========================================
  Files         270      270             
  Lines       33102    35742   +2640     
=========================================
+ Hits        11106    11385    +279     
- Misses      21996    24357   +2361
Impacted Files Coverage Δ
tests/POW/test_POW.cpp 82.91% <0%> (-1.3%) ⬇️
src/libData/AccountData/AccountStoreSC.tpp 3.11% <0%> (-1.04%) ⬇️
src/libData/AccountData/AccountStore.cpp 61.32% <0%> (-0.55%) ⬇️
src/libNode/PoWProcessing.cpp 0% <0%> (ø) ⬆️
src/libNode/FinalBlockProcessing.cpp 0% <0%> (ø) ⬆️
src/libDirectoryService/DSBlockPreProcessing.cpp 0% <0%> (ø) ⬆️
src/libDirectoryService/PoWProcessing.cpp 0% <0%> (ø) ⬆️
src/libUtils/Logger.h 100% <0%> (ø) ⬆️
src/libPOW/pow.h 100% <0%> (ø) ⬆️
src/libNode/DSBlockProcessing.cpp 0% <0%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 675664a...41e0ebf. Read the comment docs.

@ansnunez ansnunez merged commit 05e71d8 into master Jul 29, 2019
@ansnunez ansnunez changed the title add checksum check Add checksum check Jul 29, 2019
@n-hutton n-hutton deleted the feature/addchecksum branch August 8, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requesting new features Ready Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants