[WIP] Simplify dependencies #30
Conversation
|
|
||
| # Dependencies | ||
| FIND_PACKAGE(Boost 1.33 REQUIRED COMPONENTS filesystem system unit_test_framework) | ||
| INCLUDE_DIRECTORIES(${Boost_INCLUDE_DIRS}) |
There was a problem hiding this comment.
❓ Do we still need to specify -lboost_system -lboost_filesystem in CMAKE_EXE_LINKER_FLAGS above? It seems like this is all covered in the individual projects.
There was a problem hiding this comment.
➡️ Now that Travis-CI is set up, I was able to remove these lines and see that the build still works without them.
| @@ -3,8 +3,5 @@ json_spirit_reader.cpp | |||
| json_spirit_value.cpp | |||
| json_spirit_writer.cpp) | |||
|
|
|||
| FIND_PACKAGE(Boost 1.34 REQUIRED) | |||
There was a problem hiding this comment.
❓ This one says version 1.34, but others said 1.33. I used 1.33 in the updated CMakeLists.txt file. Should it be changed to something else?
There was a problem hiding this comment.
📝 I'm trying to figure out how to more easily install specific Boost versions in Travis CI for build validation.
| FIND_PACKAGE(Boost 1.33 REQUIRED COMPONENTS filesystem system unit_test_framework) | ||
| INCLUDE_DIRECTORIES(${Boost_INCLUDE_DIRS}) | ||
|
|
||
| FIND_PACKAGE(OpenSSL REQUIRED) |
There was a problem hiding this comment.
There was a problem hiding this comment.
📝 This appears to be working on Travis CI.
| @@ -31,5 +31,20 @@ if(NOT IS_LOOKUP_NODE) | |||
| endif() | |||
| endif() | |||
|
|
|||
| if(NOT WIN32) | |||
| SET( LevelDB_LIBRARIES leveldb ) | |||
There was a problem hiding this comment.
📝 This will need to change as part of #7, but for now I did not make any changes to the existing behavior on non-Windows systems.
sharwell
force-pushed
the
dependencies
branch
from
a90cb0d
to
09d6148
Compare
|
Marking as a WIP. This PR was ignored and eventually conflicted with recent merges. |
🔗 Related to #19