Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[q4-working-branch] ZIL-5326: remove dependency on Python3 #3742

Merged
merged 7 commits into from Aug 14, 2023

Conversation

yaron-zilliqa
Copy link
Contributor

Description

  • Update vcpkg baseline.
  • Remove dependency on vcpkg's Python3 and rely on the one from the distro.
  • Reduce the number of OCaml dependencies that are compiled.

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test

@github-actions github-actions bot changed the title ZIL-5326: remove dependency on Python3 [q4-working-branch] ZIL-5326: remove dependency on Python3 Aug 11, 2023
@github-actions github-actions bot added this to PRs in development in Core Aug 11, 2023
Steve-White-UK
Steve-White-UK previously approved these changes Aug 11, 2023
Core automation moved this from PRs in development to PRs approved - ready to merge! Aug 11, 2023
Core automation moved this from PRs approved - ready to merge! to PRs needing review Aug 11, 2023
Steve-White-UK
Steve-White-UK previously approved these changes Aug 14, 2023
Core automation moved this from PRs needing review to PRs approved - ready to merge! Aug 14, 2023
Core automation moved this from PRs approved - ready to merge! to PRs needing review Aug 14, 2023
Core automation moved this from PRs needing review to PRs approved - ready to merge! Aug 14, 2023
@yaron-zilliqa yaron-zilliqa merged commit b99e916 into q4-working-branch Aug 14, 2023
2 checks passed
@yaron-zilliqa yaron-zilliqa deleted the feat/ZIL-5326 branch August 14, 2023 15:34
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Aug 14, 2023
yaron-zilliqa added a commit that referenced this pull request Aug 23, 2023
* Remove Python3 port and mentions in CMakeLists.txt  & vcpkg manifest files.
* Update the baseline to tag 2023.07.21.
* Use Boost.Process to run download_incr_DB.py with python3.
* Switch boost::filesystem -> std::filesystem.
* Experimental use of vcpkg binary caching in Dockerfile.
yaron-zilliqa added a commit that referenced this pull request Sep 25, 2023
* Made modifications to logger to make LOG_MARKER very quiet
* Changed flag in lookup.cpp to send everything to dsgaurd
* Replaced isolated-server-accounts.json with single entry for use with the scripts:
   FundFromPrimaryAccount.ts in the hardhat EvmAcceptanceTests script dir
* Updated constants.xml
* reduced extra time for consensus as described in Zelensky doc.
* localdev.py now defaults to using isolated-server-accounts
* ZIL-5326: remove dependency on Python3 (#3742)
* Use Boost.Process to run download_incr_DB.py with python3.
* Switch boost::filesystem -> std::filesystem.
* Experimental use of vcpkg binary caching in Dockerfile.
* p2pcomm refactor pt.1
* Sending part, relaxed blacklisting policy
* Don't assign empty pubkeys
* Ooutgoing connections to multiplier nodes follow the old protocol (w/reconnects)
* Remove dependency on libevent.
* Upgraded Blacklist to to be keyed by ip/port/node combo.
   This is only a partial implementation, need to do the same for whitelist and push through rest of arch.
   This change needs to be done in such a way that preserves existing functionality at the ip level.
* Fix reciept output as per spec (#3759)
* Fix codehash to get only contract code hash (#3744) (#3763)
* Modify PoW submission for ds only diff (#3765)
* Fix tests
* Small adjustments and removal of unwanted part of the protocol, originally introduced to overcome limitations of godupliactor in release 8.x (#3786)
* Change m_noKill -> m_kill in daemon.
* Remove dead code

---------

Co-authored-by: stephen <steve.white@swdemon.com>
Co-authored-by: Bartosz Zawistowski <39065214+bzawisto@users.noreply.github.com>
Co-authored-by: bzawisto <bartosz@zilliqa.com>
Co-authored-by: Stephen White <93026204+Steve-White-UK@users.noreply.github.com>
Co-authored-by: Valeriy Zamaraiev <valeriy@zilliqa.com>
Co-authored-by: Artem <artgor4github@gmail.com>
Co-authored-by: chetan-zilliqa <66236813+chetan-zilliqa@users.noreply.github.com>
Co-authored-by: S4eed <saeed@zilliqa.com>
Co-authored-by: saeed <saeed@pop-os.localdomain>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Core
  
PRs done (merged)
Development

Successfully merging this pull request may close these issues.

None yet

2 participants