Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Merge q4-working-branch to master #3780

Merged
merged 42 commits into from Sep 25, 2023

Conversation

yaron-zilliqa
Copy link
Contributor

Description

Backward Compatibility

  • This is not a breaking change
  • This is a breaking change

Review Suggestion

Status

Implementation

  • ready for review

Integration Test (Core Team)

  • local machine test
  • small-scale cloud test

Steve-White-UK and others added 19 commits August 1, 2023 16:42
Changed flag in lookup.cpp to send everything to dsgaurd
Replaced isolated-server-accounts.json with single entry for use with the scripts :
   FundFromPrimaryAccount.ts in the hardhat EvmAcceptanceTests script dir
Updated constants.xml
   open telemetry settings for localdev.py
   reduced extra time for consensus as described in Zelensky doc.

Did basic startup tests

Note this is derived from master

updated localdev.py to start the appropriate number of nodes

localdev.py now defaults to using isolated-server-accounts

# it is sufficient to use this to bring up the system once you have edited your hosts to reflect ip address from minikube ip

./scripts/localdev.py up
Changed flag in lookup.cpp to send everything to dsgaurd
Replaced isolated-server-accounts.json with single entry for use with the scripts :
   FundFromPrimaryAccount.ts in the hardhat EvmAcceptanceTests script dir
Updated constants.xml
   open telemetry settings for localdev.py
   reduced extra time for consensus as described in Zelensky doc.

Did basic startup tests

Note this is derived from master

updated localdev.py to start the appropriate number of nodes

localdev.py now defaults to using isolated-server-accounts

# it is sufficient to use this to bring up the system once you have edited your hosts to reflect ip address from minikube ip

./scripts/localdev.py up
Co-authored-by: bzawisto <bartosz@zilliqa.com>
* Fixing test

* Increasing POW window

---------

Co-authored-by: bzawisto <bartosz@zilliqa.com>
* Remove Python3 port and mentions in CMakeLists.txt  & vcpkg manifest files.
* Update the baseline to tag 2023.07.21.
* Use Boost.Process to run download_incr_DB.py with python3.
* Switch boost::filesystem -> std::filesystem.
* Experimental use of vcpkg binary caching in Dockerfile.
* Fixing test

* Increasing POW window

* Fixing errorneous test

---------

Co-authored-by: bzawisto <bartosz@zilliqa.com>
* Add TODOs to fix

* p2pcomm refactor pt.1

* update #2, sending part, relaxed blacklisting policy

* update #3, some wiring

* fixing one stupid thing

* more fixes

* redundant log message eliminated

* dont assigh empty pubkeys

* fix #1

* hotfix about l2 comm

* extra logging

* fix cv_setRejoinRecovery

* fix cv_dsInfoUpdate

* fix cv_shardStruct

* fix cv_vcDsBlockProcessed

* fix cv_vcFinalBlockProcessed

* fix cv_dsLeaderTxnPool

* fix cv_setStateDeltasFromSeed

* fix cv_setCosigRewardsFromSeed

* p2p distributed test tool

* build fix

* extra logging

* Fix Dockerfile to add neccassary apt-get update

* outgoing connections to multiplier nodes follow the old protocol (w/reconnects)

* attempt to fix GetDSLeaderTxPool

* libevent gone

* some TODOs explained

* Just a checkpoint locally

* Fixing test

* Made modifications to logger to make LOG_MARKER very quiet
Changed flag in lookup.cpp to send everything to dsgaurd
Replaced isolated-server-accounts.json with single entry for use with the scripts :
   FundFromPrimaryAccount.ts in the hardhat EvmAcceptanceTests script dir
Updated constants.xml
   open telemetry settings for localdev.py
   reduced extra time for consensus as described in Zelensky doc.

Did basic startup tests

Note this is derived from master

updated localdev.py to start the appropriate number of nodes

localdev.py now defaults to using isolated-server-accounts

# it is sufficient to use this to bring up the system once you have edited your hosts to reflect ip address from minikube ip

./scripts/localdev.py up

* Made modifications to logger to make LOG_MARKER very quiet
Changed flag in lookup.cpp to send everything to dsgaurd
Replaced isolated-server-accounts.json with single entry for use with the scripts :
   FundFromPrimaryAccount.ts in the hardhat EvmAcceptanceTests script dir
Updated constants.xml
   open telemetry settings for localdev.py
   reduced extra time for consensus as described in Zelensky doc.

Did basic startup tests

Note this is derived from master

updated localdev.py to start the appropriate number of nodes

localdev.py now defaults to using isolated-server-accounts

# it is sufficient to use this to bring up the system once you have edited your hosts to reflect ip address from minikube ip

./scripts/localdev.py up

* Increasing POW window

* Upgraded Blacklist to to be keyed by ip/port/node combo.
This is only a partial implementation, need to do the same for whitelist and push through rest of arch.

This change needs to be done in such a way that preserves existing functionality at the ip level.

* Upgraded Blacklist to to be keyed by ip/port/node combo.
This is only a partial implementation, need to do the same for whitelist and push through rest of arch.

This change needs to be done in such a way that preserves existing functionality at the ip level.

* Upgraded Blacklist to to be keyed by ip/port/node combo.
This is only a partial implementation, need to do the same for whitelist and push through rest of arch.

This change needs to be done in such a way that preserves existing functionality at the ip level.

* Upgraded Blacklist to to be keyed by ip/port/node combo.
This is only a partial implementation, need to do the same for whitelist and push through rest of arch.

This change needs to be done in such a way that preserves existing functionality at the ip level.

* Fixing errorneous test

* Upgraded Blacklist to to be keyed by ip/port/node combo.
This is only a partial implementation, need to do the same for whitelist and push through rest of arch.

This change needs to be done in such a way that preserves existing functionality at the ip level.

* Reverted newer tests

* Reverted newer tests
Turned off special handling for multiplier, will remove code on next pass.

* Reverted newer tests
Turned off special handling for multiplier, will remove code on next pass.

* Some in-progress work

* Change genesis account

* Reverted newer tests
Turned off special handling for multiplier, will remove code on next pass.

---------

Co-authored-by: Valeriy Zamaraiev <valeriy@zilliqa.com>
Co-authored-by: Artem <artgor4github@gmail.com>
Co-authored-by: bzawisto <bartosz@zilliqa.com>
* simplified n_parallel jobs

* simplified n_parallel jobs
Co-authored-by: chetan-zilliqa <66236813+chetan-zilliqa@users.noreply.github.com>
…3773)

* Update vcpkg tag to 2023.07.21.
* Remove some 3rd party dependencies.
* Use vcpkg binary caching.
* Fixing test

* Increasing POW window

* Fixing errorneous test

* Some in-progress work

* Change genesis account

* Doesn't compile but we're getting there

* Further progress with desharding

* Further work with txns dispatching

* Further progress with desharding

* Comilation fix

---------

Co-authored-by: bzawisto <bartosz@zilliqa.com>
* CHeckpoint of framework for a new multiplier.

* CHeckpoint of framework for a new multiplier.
Upgraded with script from Yaron, massaged a little for new multiplier.

* CHeckpoint of framework for a new multiplier.
Upgraded with script from Yaron, massaged a little for new multiplier.

* CHeckpoint of framework for a new multiplier.
Upgraded with script from Yaron, massaged a little for new multiplier.

* A few more hacks to get things up, not perfect but good enough for toady.

* Mightly checkpoint

* Mightly checkpoint after fixing a couple more bugs

* Mightly checkpoint after fixing a couple more bugs

* Rewrite original now I understand it, making minimal changes

* Rewrite original now I understand it, making minimal changes

* Rewrite original now I understand it, making minimal changes

* Rewrite original now I understand it, making minimal changes

* Rewrite original now I understand it, making minimal changes

* Rewrite original now I understand it, making minimal changes

* Rewrite original now I understand it, making minimal changes

* First version of C++ Multiplier now working with Native version of code.

* First version of C++ Multiplier now working with Native version of code.

* Rewrite original now I understand it, making minimal changes

* First version of C++ Multiplier now working with Native version of code.
* .

* First version of C++ Multiplier now working with Native version of code.
* Add parallel tests to q4 branch

* Disable parallel on contract deployment tests

* Add new changes

* Disable parallel on contract deployment tests

---------

Co-authored-by: saeed <saeed@pop-os.localdomain>
@github-actions github-actions bot added this to PRs in development in Core Sep 14, 2023
@github-actions github-actions bot changed the title Merge q4-working-branch to master [master] Merge q4-working-branch to master Sep 14, 2023
@yaron-zilliqa yaron-zilliqa force-pushed the merge-q4-working-branch-to-master branch from 371d887 to edde918 Compare September 14, 2023 15:32
@yaron-zilliqa yaron-zilliqa force-pushed the merge-q4-working-branch-to-master branch from 40104cb to 4fb808a Compare September 20, 2023 11:10
@Steve-White-UK Steve-White-UK marked this pull request as draft September 20, 2023 19:57
Steve-White-UK and others added 3 commits September 21, 2023 13:11
…nally introduced to overcome limitations of godupliactor in release 8.x (#3786)
* Fixing test

* Increasing POW window

* Fixing errorneous test

* Some in-progress work

* Change genesis account

* Doesn't compile but we're getting there

* Further progress with desharding

* Further work with txns dispatching

* Further progress with desharding

* Comilation fix

* Some progress with deshard and consensus fixes

* Some more helpful printfs

* Removing microblock consensus

* Remove microblock consensus (next part)

* Remove microblock consensus - next

* Remove microblock consensus (next)

* Remove microblock consensus part X

* Remove microblocks - next part

* Remove microblock consensus - further work

* Remove mb consensus - further work

* Remove mb consensus - further work

* Remove dead code

* Regenerated cache

---------

Co-authored-by: bzawisto <bartosz@zilliqa.com>
@yaron-zilliqa yaron-zilliqa force-pushed the merge-q4-working-branch-to-master branch 5 times, most recently from bd4d364 to f8c1c09 Compare September 22, 2023 21:01
@yaron-zilliqa yaron-zilliqa force-pushed the merge-q4-working-branch-to-master branch from f8c1c09 to a4bf6d1 Compare September 22, 2023 21:38
@yaron-zilliqa yaron-zilliqa force-pushed the merge-q4-working-branch-to-master branch 2 times, most recently from d622040 to 7ce94a1 Compare September 25, 2023 08:20
@yaron-zilliqa yaron-zilliqa force-pushed the merge-q4-working-branch-to-master branch from 7ce94a1 to 528d400 Compare September 25, 2023 08:43
@yaron-zilliqa yaron-zilliqa force-pushed the merge-q4-working-branch-to-master branch from e1f65d1 to 4aaa77c Compare September 25, 2023 10:00
Copy link
Contributor

@Steve-White-UK Steve-White-UK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this code and I am happy with the functionality that I tested.

I requested that the native directory not be included in this merge as it was the subject of many comments and was never intended as part of the release it was submitted in error.

Core automation moved this from PRs in development to PRs approved - ready to merge! Sep 25, 2023
@yaron-zilliqa yaron-zilliqa marked this pull request as ready for review September 25, 2023 11:43
@yaron-zilliqa yaron-zilliqa merged commit f2ee0c4 into master Sep 25, 2023
4 checks passed
Core automation moved this from PRs approved - ready to merge! to PRs done (merged) Sep 25, 2023
@yaron-zilliqa yaron-zilliqa deleted the merge-q4-working-branch-to-master branch September 25, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Core
  
PRs done (merged)
Development

Successfully merging this pull request may close these issues.

None yet

6 participants