Skip to content
This repository has been archived by the owner on Jun 29, 2021. It is now read-only.

Patch Kaya RPC to work with latest zilliqa-js #63

Merged
merged 19 commits into from
Dec 6, 2018
Merged

Conversation

edison0xyz
Copy link
Contributor

@edison0xyz edison0xyz commented Dec 6, 2018

Description

CC: @evesnow91 @mickys @bobio2018

Review Suggestion

Run test/scripts/TestBlockchain.js to verify that the solution works

Status

Implementation

  • ready for review

Copy link

@iantanwx iantanwx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments, which are not critical.

components/scilla/scilla.js Outdated Show resolved Hide resolved
components/wallet/wallet.js Outdated Show resolved Hide resolved
const pk = zilliqa.util.generatePrivateKey();
const address = zilliqa.util.getAddressFromPrivateKey(pk);
const pk = zCrypto.generatePrivateKey();
const address = zCrypto.getAddressFromPrivateKey(pk);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, @zilliqa-js/account supports BIP-39. I suggest you use the Wallet class in conjunction with a passphrase to generate these accounts, as that makes it repeatable between runs of kaya.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logged this as an issue. Will work on it next time. #64

@edison0xyz edison0xyz merged commit c6a73c0 into master Dec 6, 2018
@edison0xyz edison0xyz deleted the patch/newjslib branch February 16, 2019 20:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants