Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

test: put test cases in ts instead of json #361

Merged
merged 2 commits into from Aug 21, 2021
Merged

Conversation

ghost
Copy link

@ghost ghost commented Aug 20, 2021

Description

This PR puts the test cases in TS instead of JSON since it's a simpler way and JSON does not support comments.
Also, it reduces the number of schnorr test vectors from 100 to 10 shortening the test duration from around 89s to 19s.

Motivation and Context

How has this been tested?

yarn bootstrap && yarn test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost requested review from AmritKumar, bb111189, renlulu and teye as code owners August 20, 2021 03:55
@ghost ghost changed the title test: put testcases in ts instead of json test: put test cases in ts instead of json Aug 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2021

Codecov Report

Merging #361 (48e1868) into dev (4207ab7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #361   +/-   ##
=======================================
  Coverage   80.82%   80.82%           
=======================================
  Files          44       44           
  Lines        1804     1804           
  Branches      306      306           
=======================================
  Hits         1458     1458           
  Misses        345      345           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4207ab7...48e1868. Read the comment docs.

@ghost ghost closed this Aug 20, 2021
@ghost ghost reopened this Aug 20, 2021
@ghost ghost force-pushed the test/testcases-in-ts branch from cd89ee8 to b9a0c0f Compare August 20, 2021 04:27
@ghost ghost closed this Aug 20, 2021
@ghost ghost reopened this Aug 20, 2021
@bb111189 bb111189 merged commit 3f9fe40 into dev Aug 21, 2021
@bb111189 bb111189 deleted the test/testcases-in-ts branch August 21, 2021 03:18
@ghost ghost mentioned this pull request Aug 21, 2021
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants