Skip to content
This repository has been archived by the owner on May 26, 2023. It is now read-only.

chore: pre-commit hook includes testing #364

Merged
merged 1 commit into from
Aug 21, 2021

Conversation

ghost
Copy link

@ghost ghost commented Aug 21, 2021

Description

This PR includes yarn bootstrap && yarn test in yarn validate which runs with pre-commit hook.

Motivation and Context

Now it makes sense to include yarn bootstrap && yarn test in yarn validate. Because testing duration is much shorter than before (89s -> 19s) since #361.

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Add tests to cover changes as needed.
  • Update documentation as needed.

@ghost ghost requested review from AmritKumar and bb111189 as code owners August 21, 2021 13:01
@ghost ghost changed the title chore: include testing for validation chore: pre-commit hook includes testing Aug 21, 2021
@ghost ghost force-pushed the chore/add-testing-for-validation branch from 07b52e2 to a48f906 Compare August 21, 2021 13:04
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2021

Codecov Report

Merging #364 (a48f906) into dev (98da52e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #364   +/-   ##
=======================================
  Coverage   80.82%   80.82%           
=======================================
  Files          44       44           
  Lines        1804     1804           
  Branches      306      306           
=======================================
  Hits         1458     1458           
  Misses        345      345           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98da52e...a48f906. Read the comment docs.

@bb111189 bb111189 merged commit 8887821 into dev Aug 21, 2021
@bb111189 bb111189 deleted the chore/add-testing-for-validation branch August 21, 2021 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants