-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/adapter json schema validations #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - do you think we need any migrations in case someone did key in a negative value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnyrahul LGTM
@chandrasekharan-zipstack Assuming these new validations would only fire for new adapters or while editing existing adapters, a migration might not be required. Should be ok. |
What
No field level validation it wasallowing the user to key in negative/floating values,
Why
Adapter improvements
How
json schema validations - https://json-schema.org/understanding-json-schema/reference/numeric
Relevant Docs
Related Issues or PRs
Dependencies Versions / Env Variables
Notes on Testing
...
Screenshots
...
Checklist
I have read and understood the Contribution Guidelines.