Fix/adapter json schema validations #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
johnyrahul
requested review from
gaya3-zipstack,
a team and
kirtimanmishrazipstack
and removed request for
a team
chandrasekharan-zipstack
approved these changes
May 27, 2024
vishnuszipstack
approved these changes
May 27, 2024
@chandrasekharan-zipstack Assuming these new validations would only fire for new adapters or while editing existing adapters, a migration might not be required. Should be ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
No field level validation it wasallowing the user to key in negative/floating values,
Why
Adapter improvements
How
json schema validations - https://json-schema.org/understanding-json-schema/reference/numeric
Relevant Docs
Related Issues or PRs
Dependencies Versions / Env Variables
Notes on Testing
...
Screenshots
...
Checklist
I have read and understood the Contribution Guidelines.