Update welcome message #301
Conversation
source/config.js
Outdated
| var welcomeFmt = 'Welcome to the JavaScript chat! Please review the {0}. ' + | ||
| 'Please don\'t ask if you can ask or if anyone\'s around; just ask ' + | ||
| 'your question, and if anyone\'s free and interested they\'ll help.'; | ||
| var welcomeFmt = "Welcome to the JavaScript chat! Please review the {rulesLink}. " + |
There was a problem hiding this comment.
FWIW I think that we can use template strings :D
There was a problem hiding this comment.
I also thought so, but I decided to stick with supplant for the sake of consistency with the rest of the codebase.
|
FWIW users already get a pretty big popup when they join chat apparently that tells them to report issues - |
|
Looks good, thanks! Just one small thing: could you just change the double quotes to singles? |
|
@Zirak I purposely switched to double quotes because the string contains single quotes. Are you seriously suggesting it's better to have to escape them? |
|
@kendfrey That's the style guide, single quotes, for better and for worse. |
|
In that case, you can expect a begrudging commit from me later today. |
|
Thanks @kendfrey! |
I've made some changes to the welcome message, including:
Example can be seen at https://chat.stackoverflow.com/transcript/message/42342257#42342257
Feel free to berate me on the wording, or indeed to think that I did fine.