Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persist the selected quest upon relogging #1713

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

umer-rs
Copy link
Contributor

@umer-rs umer-rs commented Aug 22, 2024

reopens the previously active quest upon logging in.

added a new boolean flag because we need to differentiate between the runescape profile changing and being logged out. we can be logged out but be logging in to the same runescape profile.

case 1: log out and log into same runescape profile -> reopen previous quest

case 2: log out and log into different runescape profile -> dont open previous quest

case 3: don't log out but hop to a different runescape profile -> dont open previous quest

could also potentially add a config option for this.

@kcjg94
Copy link
Contributor

kcjg94 commented Aug 22, 2024

I'm not sure if this should be the default (i.e. it should require a config option). If a user is doing a quest, and then moves to a different activity, on their next login it shouldn't be opening the quest helper plugin. It seems a bit invasive of the quest helper plugin to move from one plugin to itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants