Easily available custom package server #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just outline it in Markdown so I have a target to code against when recreating it.
It's not just the Elm package server API details anymore
Extremely bare bones at the moment
This lets us store files directly in the sqlite database with some nice extra support
This reverts commit 1a06dbe.
There's still some bug now where I can't pull down all-packages for some HTTPS reason
One final issue which is the problem of actually calculating file hashes for the package server instead of just always writing "some-hash"
changlinli
force-pushed
the
easily-available-custom-package-server
branch
from
5da7149
to
7a0d8b8
Compare
This was part of an unfinished commit that shouldn't have been committed
Now you can view packages!
This is what will be shared with the community!
supermario
approved these changes
May 21, 2024
There was a problem hiding this comment.
This is cool – but yeah a lot to review 😅
Some drive-by thoughts:
- SQLite as an embedded and portable DB could be worth considering rather than hand rolling another on-disk format (your design notes were incomplete so unsure if you did further exploration of this)
- You might consider extracting more of the modifications to the core Elm files if you haven't already, to keep future potential diffs against upstream cleaner. They don't look particularly large, and obviously diminishing returns when added functions need to use local types, but I notice you're mixing in imports and functions – having a clear
-- @zokkamarker where additions are clearly appended to the ends of the imports / file may help maintenance (and clarity on what's zokka divergence and what's not) in future.
I've not had a chance to try this out yet, but hope to check it out this weekend 👍
Co-authored-by: Mario Rogic <hello@mario.net.au>
|
Yep @supermario you're right on the money! I decided to go with SQLite instead. I agree with you that I should move out all the Zokka stuff to make it more clear what is new in Zokka and what is in Elm. I'll likely do that as a separate PR to combine with the pre-existing Zokka additions I have. |
This is because otherwise we'll mess with the enable executable static flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick Summary:
Creating a new custom package repository server that decouples us from GitHub and git and serves as the basis for a separate online service that can offer one-click custom package repositories. See
CUSTOM_PACKAGE_SERVER_REFERENCE_NOTES.mdfor more details.