Resolver patch #580
Merged
Resolver patch #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schaeff
reviewed
Mar 4, 2020
zokrates_core/src/compile.rs
Outdated
| type FilePath = PathBuf; | ||
|
|
||
| pub trait Resolver<E: Into<imports::Error>> { |
There was a problem hiding this comment.
Can <E: Into<imports::Error>> go on resolve rather than on the trait? I think it's good practice and it might also make things clearer
Schaeff
reviewed
Mar 4, 2020
zokrates_fs_resolver/Cargo.toml
Outdated
|
|
||
| [dependencies] | ||
| zokrates_core = { version = "0.4.2", path = "../zokrates_core" } |
There was a problem hiding this comment.
Is there a way to keep fs_resolver independent from zokrates_core? I guess having a different crate for that trait definition?
There was a problem hiding this comment.
We could introduce a "common" crate that contains the trait definition, and the trait should be more generic then.
Schaeff
reviewed
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Resolver trait for code clarity