Configuration tagging feature #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikkolasg
reviewed
Oct 11, 2021
|
@nikkolasg could you please check everything again? I made some big changes. |
nikkolasg
reviewed
Oct 12, 2021
There was a problem hiding this comment.
Nice ! So the only thing for me is to try to remove as much as possible of the if/else that should directly call the verifier and we're good !!
I was hesitating to maybe see what code looks like if we put the verifier's logic inside the scheme, so we could have APi like scheme.VerifyBeacon() - only one interface instead of Scheme + Verifier - but then the logic would be outside of the beacon package which is not great as well (or maybe put the scheme inside beacon/ ). (just thinking out loud - i'm fine to go as it is now !)
|
Ahah ok ok all good then because these were my last comments ;)
Le mar. 12 oct. 2021 à 13:25, Emmanuel ***@***.***> a écrit :
… ***@***.**** commented on this pull request.
------------------------------
In chain/beacon/node_test.go
<#31 (comment)>:
> @@ -400,7 +400,12 @@ func TestBeaconSync(t *testing.T) {
var counter = &sync.WaitGroup{}
myCallBack := func(i int) func(*chain.Beacon) {
return func(b *chain.Beacon) {
- require.NoError(t, b.Verify(bt.dpublic, utils.PrevSigDecoupling()))
+ if utils.PrevSigDecoupling() {
Do not hurry Nicolas! I will get to that code. I wanted to be sure the
path is correct before modifying the tests. It will be done by today.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#31 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATSFC4GFJQTMC2BMOAP523UGQSKNANCNFSM5FYOX6MA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
Nicolas Gailly
|
emmanuelm41
force-pushed
the
unchained-beacon
branch
from
a61736f
to
bed664d
Compare
* rename tag feature to config presets * remove old DecouplePrevSig flag and use ConfigPresetId instead
emmanuelm41
force-pushed
the
tagging-system
branch
from
7fc3192
to
e0800a4
Compare
nikkolasg
reviewed
Oct 13, 2021
nikkolasg
reviewed
Oct 13, 2021
nikkolasg
reviewed
Oct 13, 2021
nikkolasg
reviewed
Oct 13, 2021
nikkolasg
reviewed
Oct 13, 2021
emmanuelm41
added a commit
that referenced
this pull request
Oct 13, 2021
* create a scheme configuration system * refactor unchain randomness feature to use scheme configuration, making it more easy to set up * add a new CLI command to list scheme ids available
emmanuelm41
added a commit
that referenced
this pull request
Oct 13, 2021
* v1.2.0 * update go version to 1.17 * update go and protobuf version * add unchained beacon feature on code * update tests with new feature * split test jobs to check both chained and unchained randomness * regenerate proto files * fix linter issues * Scheme feature and unchained randomness refactoring (#31) * create a scheme configuration system * refactor unchain randomness feature to use scheme configuration, making it more easy to set up * add a new CLI command to list scheme ids available * regenerate protobuf files * apply go mod tidy * add docs to new added code * apply minor changes * set default scheme on client cfg * fix lint issue * change CI job names Co-authored-by: Will Scott <will@cypherpunk.email> Co-authored-by: Will Scott <will.scott@protocol.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.