Scheme configuration system and unchained randomness #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuelm41
force-pushed
the
unchained-beacon
branch
3 times, most recently
from
2ecc7e4
to
d260411
Compare
nikkolasg
reviewed
Sep 29, 2021
There was a problem hiding this comment.
Hey - great start. I think I made a lot of similar comments, so please excuse me if I'm being redundant. My main point here is that we should treat this PR as already adding a new protocol to drand, and not just a tweak. And we give a version flag to identify the logic with this new way of doing things. If we get that, then any further updates will be simpler because we can "just" create a new version flag. Obviously I'm not asking for the most generic thing already, but let's start to employ the right mindset to think about this: we are creating a new protocol version here.
Sorry for the large comments, I hope it's all right with you, and thanks for taking care of this <3
Go version update
emmanuelm41
force-pushed
the
unchained-beacon
branch
from
9574eeb
to
95dca4d
Compare
emmanuelm41
force-pushed
the
unchained-beacon
branch
from
95dca4d
to
a61736f
Compare
emmanuelm41
force-pushed
the
unchained-beacon
branch
from
a61736f
to
bed664d
Compare
emmanuelm41
changed the title
nikkolasg
reviewed
Oct 13, 2021
nikkolasg
reviewed
Oct 13, 2021
nikkolasg
reviewed
Oct 13, 2021
nikkolasg
reviewed
Oct 13, 2021
nikkolasg
reviewed
Oct 13, 2021
nikkolasg
approved these changes
Oct 13, 2021
* create a scheme configuration system * refactor unchain randomness feature to use scheme configuration, making it more easy to set up * add a new CLI command to list scheme ids available
emmanuelm41
force-pushed
the
unchained-beacon
branch
from
f1e0703
to
c8f78c1
Compare
nikkolasg
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.