Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sign message #82

Merged
merged 4 commits into from
Nov 16, 2021
Merged

sign message #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
410f454
feature(message): Add a new function to construct and sign a stacks'
neithanmo Nov 15, 2021
e1ed387
feature(message): Update sign_message test and some clean-ups in the
neithanmo Nov 15, 2021
e6c47a4
bump app version and update snapshots
neithanmo Nov 15, 2021
53d10bb
Update snapshots
neithanmo Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
25 changes: 25 additions & 0 deletions js/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,4 +239,29 @@ export default class BlockstackApp {
}, processErrorResponse);
}, processErrorResponse);
}

async sign_msg(path: string, message: string) {
const len = message.length
const stacks_message = "\x19Stacks Signed Message:\n" + `${len}` + message
const blob = Buffer.from(stacks_message)
return this.signGetChunks(path, blob).then(chunks => {
return this.signSendChunk(1, chunks.length, chunks[0]).then(async response => {
let result = {
returnCode: response.returnCode,
errorMessage: response.errorMessage,
postSignHash: null as null | Buffer,
signatureCompact: null as null | Buffer,
signatureDER: null as null | Buffer,
};
for (let i = 1; i < chunks.length; i += 1) {
// eslint-disable-next-line no-await-in-loop
result = await this.signSendChunk(1 + i, chunks.length, chunks[i]);
if (result.returnCode !== LedgerError.NoErrors) {
break;
}
}
return result;
}, processErrorResponse);
}, processErrorResponse);
}
}
44 changes: 6 additions & 38 deletions tests_zemu/tests/standard.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,59 +477,27 @@ describe('Standard', function () {
expect(testPublicKey).toEqual('02' + expectedPublicKey.slice(2, 2 + 32 * 2))

const msg = "Hello World"
const len = msg.length
const signedTx = "\x19Stacks Signed Message:\n" + `${len}` + msg
console.log(signedTx)

const unsignedTx = signedTx

// tx_hash: bdb9f5112cf2333e6b8e6fca88764083332a41923dadab84cd5065a7a483a3f6
// digest: dd46e325d5a631c99e84f3018a839c229453ab7fd8d16a6dadd7f7cf51e604c3

const blob = Buffer.from(unsignedTx)

// Check the signature
const signatureRequest = app.sign(path, blob)
const signatureRequest = app.sign_msg(path, msg)

// Wait until we are not in the main men
await sim.waitUntilScreenIsNot(sim.getMainMenuSnapshot())

await sim.compareSnapshotsAndAccept('.', `${m.prefix.toLowerCase()}-sign_message`, m.name === 'nanos' ? 1 : 2)

const signature = await signatureRequest
// TODO: Complete message signing
// current error:
// errorMessage: 'Sign/verify error : zxerr_no_data'

console.log(signature)
expect(signature.returnCode).toEqual(0x9000)
expect(signature.errorMessage).toEqual('No errors')

// @ts-ignore
//const js_signature = signedTx.auth.spendingCondition?.signature.signature

//console.log('js_signature ', js_signature)
//console.log('ledger-postSignHash: ', signature.postSignHash.toString('hex'))
//console.log('ledger-compact: ', signature.signatureCompact.toString('hex'))
//console.log('ledger-vrs', signature.signatureVRS.toString('hex'))
//console.log('ledger-DER: ', signature.signatureDER.toString('hex'))

// @ts-ignore
//unsignedTx.auth.spendingCondition.signature = createMessageSignature(signature.signatureVRS.toString('hex'))
//unsignedTx.auth.spendingCondition.signature.signature = signature.signatureVRS.toString('hex');

console.log('unsignedTx serialized ', unsignedTx.toString('hex'))
//
// const broadcast = await broadcastTransaction(unsignedTx, network);
// console.log(broadcast);
//
// expect(broadcast.reason).not.toBe("SignatureValidation");
//
// expect(signature.returnCode).toEqual(0x9000);
//

//Verify signature
const ec = new EC("secp256k1");
const msgHash = sha512_256(unsignedTx);
const len = msg.length
const data = "\x19Stacks Signed Message:\n" + `${len}` + msg
console.log(data)
const msgHash = sha512_256(data);
const sig = signature.signatureVRS.toString('hex')
const signature_obj = {
r: sig.substr(2, 64),
Expand Down