Modularize keystore functionality #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor(keys): rename `Keys` to `InMemoryKeys` refactor(keys): impl above traits for `InMemoryKeys` refactor(lightwallet): split methods between generic over keystore and `InMemoryKeys` specific style: formatting
feat(builder): impl `Builder` for zcash-primitive's Builder feat(keystore): obtain associated builder for certain keystore refactor: use new `Builder` trait
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lays the groundwork to allow different ways to store/retrieve/use cryptographic keys, mostly aimed at allowing to use ledger devices for these.
This is done by splitting the functionality of the
Keysstructure (now renamedInMemoryKeys) into different traits and then having the dependant structures (LightWalletandLightClient) act in accordance with these traits (this part is still not fleshed out completely).For this purpose, the
KeystoreandInsecureKeystoretraits were made, with the latter representing access to private data.In addition, the
Buildertrait was also made to abstract over the different type of builders available, which differ in their HSM-compatibility.This is just the groundwork and the API is not stable, that means in the future changes are expected, for example the bound on the TxProver will change to allow for HSM-compatibility.