Complete ledger integration #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(ledger): device ""id"" refactor(keys:adapters): use `Self` instead of enum name chore: bump wallet serialization version
refactor: adjust spendable notes based on ivk only feat(keystores): method to retrieve all spendable ivks refactor(wallet): initialize `Keystores` from file
refactor: don't force memory keys for lock/unlock encrypt/decrypt operations
refactor(data): use ivk in SaplingNoteData instead of extfvk, refactor(data): also for SpendableNotes refactor(sync): compute nullifier via keystore refactor(sync): use ivk instead of extfvk refactor(builder): use ivk instead of vk for adding sapling spends misc: use `to_repr()` to compare ivks
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes the integration work:
Details and notes about ledger wallet backup/restore:
1 SECP256K1 public key is stored in the file, this is used to identify the ledger in use, then N and M derivation paths are stored, which are used to retrieve all the keys when the wallet is restored, this is shows as a delay in the wallet initialization
The serialization format changes to the version have been updated accordingly.
Details and notes about notes and nullifiers:
Notes have been changed (not in the zcash lib) to not require storing the EXTFVK but rather only the IVK, this allows decryption to be done by the ledger as we don't need to retrieve the FVK (not possible on the ledger).
As a consequence, the code has been refactored to request the nullifier from the ledger, or just compute it like before if the keystore is not the ledger