Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need the multi-server "Not using multi server" logs? #1482

Closed
pliablepixels opened this issue May 15, 2016 · 2 comments · Fixed by #1499
Closed

Do we need the multi-server "Not using multi server" logs? #1482

pliablepixels opened this issue May 15, 2016 · 2 comments · Fixed by #1499

Comments

@pliablepixels
Copy link
Member

Specifically,
https://github.com/ZoneMinder/ZoneMinder/blob/66a3fef61ebd10c45968a3706021d45d027e28be/src/zm_config.cpp#L138-L143

It seems when any operation results in some access to loadConfig, this log is generated. In R1.29 this was an INFO log, which we have demoted to Debug. We can keep it in Debug, but do note that for any operation, such as cgi-bin/zms view snapshot (or jpeg),any API that does a loadConfig (like alarmStatus) will keep generating this log. Folks using zmNinja with the next release of ZM (albeit in debug mode) will be rather overwhelmed as I am using alarm status APIs extensively.

@connortechnology thoughts?

@knight-of-ni
Copy link
Member

I was thinking we should move this event to display once, during zoneminder startup only.

@pliablepixels
Copy link
Member Author

pliablepixels commented May 15, 2016

Yes, I do think that's a more appropriate place. zmLoadConfig is called by all the processes during their inits, (zma/zms/zmu/zmc) - at the C++ level I don't know what would constitute a zoneminder startup beyond initing these processes. So even if this check is done after each zmLoadConfig in all or one of these processes, that should suffice too. Of these processes, I think zms is the one that restarts the most.

In any case, I do think this debug log should go out of zmLoadConfig as its scope is more system wide and won't change often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants