You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems when any operation results in some access to loadConfig, this log is generated. In R1.29 this was an INFO log, which we have demoted to Debug. We can keep it in Debug, but do note that for any operation, such as cgi-bin/zms view snapshot (or jpeg),any API that does a loadConfig (like alarmStatus) will keep generating this log. Folks using zmNinja with the next release of ZM (albeit in debug mode) will be rather overwhelmed as I am using alarm status APIs extensively.
Yes, I do think that's a more appropriate place. zmLoadConfig is called by all the processes during their inits, (zma/zms/zmu/zmc) - at the C++ level I don't know what would constitute a zoneminder startup beyond initing these processes. So even if this check is done after each zmLoadConfig in all or one of these processes, that should suffice too. Of these processes, I think zms is the one that restarts the most.
In any case, I do think this debug log should go out of zmLoadConfig as its scope is more system wide and won't change often.
Specifically,
https://github.com/ZoneMinder/ZoneMinder/blob/66a3fef61ebd10c45968a3706021d45d027e28be/src/zm_config.cpp#L138-L143
It seems when any operation results in some access to loadConfig, this log is generated. In R1.29 this was an INFO log, which we have demoted to Debug. We can keep it in Debug, but do note that for any operation, such as cgi-bin/zms view snapshot (or jpeg),any API that does a loadConfig (like alarmStatus) will keep generating this log. Folks using zmNinja with the next release of ZM (albeit in debug mode) will be rather overwhelmed as I am using alarm status APIs extensively.
@connortechnology thoughts?
The text was updated successfully, but these errors were encountered: