-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.30.0 #1485
Comments
I think 1.30 is the correct version number. It has onvif turned on, and telemetry. These are new features. 1.29.1 would be a bug fix release. We need #1486 in to make @pliablepixels happy. Also #1478 to fix some multi-server problems. #1470 makes configuring the api a lot simpler. |
I'm hoping we get the FreeBSD port/pkg updated with the release of 1.30!
EDIT |
We should probably fix #1464 too. |
Well, there is something still messed up with the master branch. I'm placing this hear for now until I've got time to troubleshoot this further:
This is from one of my weekly builds on Fedora. UPDATE: commit 6e32b5d seems to be the cause of this. |
@knnniggett what commit did you build off? Database connections are working for me with b4b9c1f |
Strange, mine is working, as a fresh install on FreeBSD. Maybe because I already #1492? |
which .pl is generating that output? |
basically the config hasn't been initialized yet... meaning that ZoneMinder.pm hasn't been included yet. |
That output shows when I try to start zoneminder from the command line. |
Just a note that this user encountered the same problem a day after 6e32b5d was merged: At the time of my first response in that thread, I was unaware of the recent changes to database.pm. I am still looking for a possible solution, but at the moment I have not come up with a better solution other than to put it back to the way it was. |
Are we at code/issue freeze for 1.30? If not, there are a couple of benign changes (API documentation and a fix for #1493 for consideration. Neither affect zmNinja, so its your call. |
Right now the master branch still isn't working in all cases due to recent changes to the Perl code while I was on vacation. There will always be items we "need" to add to the source code, and right now I'm not willing to entertain anything other than fix the master branch and resolve what is already in this thread. |
I'd like to test master under FreeBSD before 1.30.0 release to use release branch for port. |
@knnniggett nothing for me, wasted about a week on spammers |
Release Candidate 1 is now official: Let the package building marathon begin. |
Thanks @knnniggett ! Um. I think we still need to bump the version files though. |
Not sure which file you mean. The one that matters has been bumped to 1.30.0: Along with the corresponding update script: If you are referring to the file "version" in the root folder, then no I did not bump that. That was intentional, due to the previous mass confusion from our user base caused by bumping that file too early. It'll get bumped when the release is official and not just a candidate. |
@connortechnology I don't know if you did it on purpose, but you just deleted the 1.30.0 source tarball from our releases page. Please do not do that. |
Sorry... The file that has to be changed is called version. |
okay, I give up. |
packaging uses that file. I don't think pre-releases should have a tarball called 1.30. It should 1.30.rcwhatever. I also don't think we should be checking master branch's version file to see what the latest release is. Because it is not released. We need to fix this confusion. |
I don't disagree with you, but @kylejohnson controls how the version file is used. Only he can change it as far as I know. The tarball needs to be named that way because rpm packaging scripts require it to have that name. |
Let's get this fixed before we go further. I will bug Kyle. |
Now, I am going to step away from my pc today and celebrate my wife's 40th birthday today. Please don't break anything while I am away. |
I will not. Enjoy your day and hers! |
Just don't bump the one used by version check until actual release, or all On Wed, Jun 1, 2016 at 10:52 PM, Isaac Connor notifications@github.com
|
@SteveGilvarry - don't be a spoil sport. Let's have some mayhem, shall we 👍 |
@connortechnology Why didn't you say that 4 posts ago? That file was never intended to be used that way, and nobody but you knew you were using it in that manner. The version file has been out of sync since we bumped the rest of the code to 1.29.1, which was months ago. In the short term, can't you just patch the verson file? I'm sure debian packaging scripts allow one to apply patches to the build. Alternatively, we could bump the version file in the release-1.30.0 branch, but not in the master branch. |
zmupdate.pl shows the following non-fatal warning every time it is run:
UPDATE: @connortechnology See #1527 |
@connortechnology can we do something to solve the ZMS_PATH change that everyone has to make? Assuming /zm/cgi-bin is the final resting place then we should make ZMS_PATH match apache conf. |
I'm almost tempted to say we should just configure the PATH_ZMS based on |
Hmm ... yes. Zms. WE should be able to do something. Like script a test and automatic update. |
Will it break something? We use WWWROOT/cgi-bin ... |
@abishai this would be part of the debian package scripts, and would not affect freebsd. |
I have added a few existing PR's to the 1.30 milestone, mainly where they clearly fix existing bugs. Close these out and we can RC2, any other issues or PR's that should be in now? |
What about #1542 ? That's obvious and simple to fix issue. Or it's not confirmed? |
It would be nice to get this PR in so admins could specify their mysql port/socket I understand we want to consolidate the database connections for Perl after 1.30, but merging this fix doesn't make that more difficult. It just makes the database connection logic identical and correct in the 3 Perl files currently making the connections. |
Everyone of us can sit and make a never ending list of things each of us wants to include in the next release. I can do it too. This is exactly why we haven't actually released 1.30.0 yet. It literally never ends. As soon as we merge one guy's pet project, someone else shows up and makes the same argument to merge his or her pet widget. We have to draw the line somewhere if we are ever going to call 1.30.0 a release. So the answer to "what about...." is no. Wait until the next release after 1.30.0. Yes, I'm being a hard ass about this, and I'm not going to enter into a discussion about it because my time it very valuable to me. |
I can wait, I'll continue to apply the patches to my own production system. Figured I'd present it since Steve asked. No worries, I'd prefer ZM release often and not be like those projects which don't release an official stable version for years because they lost their cadence. |
👍 @knnniggett. I'd rather see more point releases with small changes rather than infrequent releases with all the stuff that everybody wants in... |
Discovered a show stopper for all systems running the latest version of libjpeg-turbo 1.5.0. When we run into an issue like this, not only do we need to merge it, but we need to allow sufficient time for it to be tested by the community. This unfortunately means it will be a bit longer before 1.30.0 is released. I do intend to create an RC2 once #1548 is merged. |
Debian moved to libjpeg-turbo v1.5.0 about a month ago: https://tracker.debian.org/pkg/libjpeg-turbo |
@onlyjob tried to create alioth account to submit this but no joy tonight. New dependencies from zmtelemetry.pl. |
@knnniggett If possible can we document so others can follow suit. And check out annotated tags so git describe works for release with having to add --tags. |
@SteveGilvarry I will add "update the release documentation in the wiki" to my list of things I can do when I'm not playing fireman. I do appreciate your interest and look forward to having help. However, I don't expect to get to that until after the 1.30.0 release. The good news is there are far fewer steps than what used to be. Due to time constraints, I'm going to create the next RC2 tag via the normal method. I see what you are saying about annotated tags, but I could use some help understanding exactly what this seemingly redundant release information is useful for. I'm not saying I won't do it, but knowing some use cases will help me figure out what information to put in it. Here is the most recent annotated tag from v.127:
I don't find this particular information to be too useful, do you? So let's decide what to put in the annotation, and I'll do it for the 1.30.0 release. |
Let's me use git describe for versioning, and gives count of commits since
|
Okay, so RC2 is out. I made the mistake of leaving my .git folder in the tarball attached to draft release.... note to self. Don't do that. It ballooned the archive by a factor of 10. @SteveGilvarry That sounds reasonable, but what do you want the contents of the annotation to be?
And can one add an annotation after the tag has already been created? |
Yes same as the 1.27 one works fine. I think I saw something about On Thu, 7 Jul 2016 at 9:36 AM, Andrew Bauer notifications@github.com
|
Force updated the tag like so: It looks like it worked, but it is ugly: abauer@Ubuntu-Desktop:~/git/ZoneMinder$ git describe
v1.30.0-rc2
abauer@Ubuntu-Desktop:~/git/ZoneMinder$ git show v1.30.0-rc2
tag v1.30.0-rc2
Tagger: Andy Bauer <knnniggett@hotmail.com>
Date: Wed Jul 6 18:53:33 2016 -0500
tag v1.30.0-rc2
Tagger: Andrew Bauer <knnniggett@users.sourceforge.net>
Date: Wed Jul 6 18:49:07 CDT 2016
tag v1.30.0-rc2
Tagger: Andy Bauer <knnniggett@hotmail.com>
Date: Wed Jul 6 18:48:37 2016 -0500
tag v1.30.0-rc2
Tagger: Andrew Bauer <knnniggett@users.sourceforge.net>
Date: Wed Jul 6 18:49:07 CDT 2016
commit 4873683f01eb66634dd857ef7904f5c9aaeb01dc
Merge: 257ce2b 75a9860
Author: Steve Gilvarry <SteveGilvarry@users.noreply.github.com>
Date: Thu Jul 7 00:13:54 2016 +1000
Merge pull request #1548 from knnniggett/libjpegturbo
fix jpeg buffer too small The information you see does not show up in the editor, allowing me to clean it up, so I'm declaring it good enough for now. |
OK so hopefully a normal annotated tag does it cleaner, but desired result is achieved, so thanks for giving it a go. And were you referring to the export email thread in the forum when you said issues? |
#1550 |
Not sure if this is relevant here but I've seen
|
Release 1.30.0 The Day that Never Comes, has finally come. @SteveGilvarry I think I did the annotated tags right |
Looks good @knnniggett thanks for your work and perseverance in getting it out the door. |
This issue has been created as a placeholder to document what we need to address before our next release.
Due to some of the changes we've implemented, I plan to create a draft release before releasing. I estimate the draft release process to take approx. 1 month.
@ ZoneMinder Team
@kylejohnson
@knnniggett
Review and test Improved WS-Discovery standard compliance #1411review and merge Update zmupdate #1484review and merge pass in the server url into the monitor object to use instead of the … #1478Address unlink error message remove one unlink, add better error reporting to the rest #1500@connortechnology
discuss and implement a solution to Do we need the multi-server "Not using multi server" logs? #1482 (see pr move multiserver message to display once during startup only #1499)Update zmupdate #1484Fix zone edit #1501@pliablepixels
Update image view #1486pass in the server url into the monitor object to use instead of the … #1478 to fix some multi-server problems.Api improvements #1470 makes configuring the api a lot simpler.@SteveGilvarry
The text was updated successfully, but these errors were encountered: