Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move multiserver message to display once during startup only #1499

Merged
merged 3 commits into from
May 24, 2016

Conversation

knight-of-ni
Copy link
Member

fixes #1482

It should work, but I haven't tested this yet.

@knight-of-ni knight-of-ni mentioned this pull request May 24, 2016
@knight-of-ni
Copy link
Member Author

single server mode tested and works as intended.

@connortechnology
Copy link
Member

I put these lines in for debugging purposes. If people don't want to see them, they shouldn't have debugging on.

I object to them being removed. I propose that we increase the debug level required to see them to 3 instead.

@knight-of-ni
Copy link
Member Author

knight-of-ni commented May 24, 2016

The messages are being moved, not removed.

Can you explain what it is you want to see that won't be displayed with this pr?

@connortechnology
Copy link
Member

They are moved to a perl script, which uses different code to parse the config. I sometimes run zmc manually (when debugging). I don't object to the lines in zmpkg.pl.

Anyways, that is my opinion.

@knight-of-ni
Copy link
Member Author

Fair enough. We can do both.

@knight-of-ni
Copy link
Member Author

I have added debug level 3 message back into zm_config.cpp.

I have changed the wording slightly to make them appear more informational and less fatal (tried to minimize use of the words "no" and "not" as best I could).

I'm tired of explaining to end users in the forums, that these messages do not necessarily mean there is a problem. At least three people in the forums have broken their system trying to "fix" these messages. ...probably can't fix stupid, but I'd like to try.

@knight-of-ni
Copy link
Member Author

whoops. missed bracket.

@connortechnology connortechnology merged commit 0522b03 into ZoneMinder:master May 24, 2016
@knight-of-ni knight-of-ni deleted the mserver_msg branch December 23, 2016 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do we need the multi-server "Not using multi server" logs?
2 participants