Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for port/socket #1492

Closed
wants to merge 2 commits into from
Closed

Add support for port/socket #1492

wants to merge 2 commits into from

Conversation

josh4trunks
Copy link
Contributor

@josh4trunks josh4trunks commented May 18, 2016

Logic is added to handle specified port / unix file socket for database connections.
For example, the following now all work as expected...

ZM_DB_HOST=localhost
ZM_DB_HOST=REMOTE_HOST:1234
ZM_DB_HOST=localhost:/path/to/non-default.sock

For the API to work in the same manner, this PR must be merged. #1470

Fixes #901

@josh4trunks
Copy link
Contributor Author

@SteveGilvarry @connortechnology This is ready for review/merge.

@josh4trunks josh4trunks mentioned this pull request May 18, 2016
@josh4trunks
Copy link
Contributor Author

@knnniggett @connortechnology
Looking at 58b5194, is the plan moving forward to have the Perl database connection in two places?
If so I can adjust my PR accordingly.

@connortechnology
Copy link
Member

This is going to be left for the next release.

Ideally, there should be only 1 place.

@josh4trunks
Copy link
Contributor Author

josh4trunks commented May 20, 2016

Ok, so no mysql port/socket support till 1.30.1? (I don't know the numbering)

Or did you mean no database connection merging? I can adjust this PR so it works either way, the logic is pretty simple.

@josh4trunks
Copy link
Contributor Author

Closed in favor of #1498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants