Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to completely get rid of jiggling montage layout (montage.js) #4032

Merged
merged 3 commits into from
May 23, 2024

Conversation

IgorA100
Copy link
Contributor

No description provided.

@IgorA100 IgorA100 marked this pull request as ready for review May 22, 2024 20:05
@IgorA100
Copy link
Contributor Author

This is an improvement #4031
Please check.

@connortechnology
Copy link
Member

Still pretty jiggly, but it settles, so I'm fine with it.

@IgorA100
Copy link
Contributor Author

I get no more than 1 scrollbar switch.

@IgorA100
Copy link
Contributor Author

If you are satisfied, it is advisable to approve this PR, otherwise I am starting to get confused....

@connortechnology connortechnology merged commit 51c3e79 into ZoneMinder:master May 23, 2024
9 of 17 checks passed
@connortechnology
Copy link
Member

For some reason merging this in addition to other merges has broken the layout again. It might have been my implementing an auto-scale for initial load.

Screenshot_20240523_135119

@IgorA100
Copy link
Contributor Author

@connortechnology
You changed a lot in my code.
I'm not ready to find a reason right now.
from Freeform renamed to Auto In DB? If not, there will be problems. I deliberately left this code temporarily.
I don’t yet know the consequences of this commit b63412a and others.

There was no need to make that many changes to the code at this point. First, you need to “test” the code so that there are no bugs, and only then do refactoring.

I need to completely update my ZM and do the research all over again.
Forgive me, this is just my IMHO.

@IgorA100
Copy link
Contributor Author

@connortechnology

There is a lot in the code that I wrote that needs refactoring.
I deliberately left many aspects “as is”. And I planned to start refactoring in 1-2 months, when all the bugs were debugged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants