Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support marking test as favorites and filtering them #508

Closed
6 tasks done
enudler opened this issue Oct 18, 2020 · 6 comments · Fixed by #533
Closed
6 tasks done

Support marking test as favorites and filtering them #508

enudler opened this issue Oct 18, 2020 · 6 comments · Fixed by #533
Assignees
Labels
1.6.0 backend enhancement New feature or request good first issue Good for newcomers UI

Comments

@enudler
Copy link
Collaborator

enudler commented Oct 18, 2020

Is your feature request related to a problem? Please describe.
In the tests page, I want an option to see tests that I marked as favorite
Describe the solution you'd like

  • add to tests data model property is_favorite (sequlize)
  • support migrating of the above column (sequlize)
  • support Update/Create test with is_favorite
  • support Get Tests by is_favorite query param (filter)
  • add support in tests page in the UI (toggle)
  • add supports in tests page in the UI (Mark test as favorite)

Additional context
A very similar thing was done in reports, see revision: a00f10a

@enudler enudler added enhancement New feature or request good first issue Good for newcomers UI backend Hacktoberfest labels Oct 18, 2020
@swatikothari
Copy link
Contributor

Can I take this one?

@enudler
Copy link
Collaborator Author

enudler commented Oct 19, 2020

Hi @swatikothari
I will assign it to you,
If you have any question you can ask here or in our slack workspace

@enudler
Copy link
Collaborator Author

enudler commented Oct 23, 2020

Hi @swatikothari
How is it going with this issue?
LMK if you need any help

@swatikothari
Copy link
Contributor

swatikothari commented Oct 25, 2020

@enudler - For the last two tasks, do you mean add a toggle to support marking favorite or a toggle to show all tests that have been marked favorite and a separate way to mark individual tests as favorite?
EDIT: Nvm, found the features for reports. Do we have a preferred place for where the favorites star icon should be visible for tests?

@enudler
Copy link
Collaborator Author

enudler commented Oct 26, 2020

hi @swatikothari
Left to test name (need to align and move the input fields to the right)

swatikothari pushed a commit to swatikothari/predator that referenced this issue Oct 30, 2020
@swatikothari
Copy link
Contributor

@enudler Can you please take a look at the PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.6.0 backend enhancement New feature or request good first issue Good for newcomers UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants