fix(invalid_test): show error popup if test data is invalid #516
Conversation
|
Hello @enudler , could you check this PR? |
|
Hi @anusha5695 |
|
@manorlh would you review this too please? |
| @@ -271,6 +309,7 @@ class getTests extends React.Component { | |||
| autoHideDuration={4000} | |||
| onRequestClose={this.handleSnackbarClose} | |||
| />} | |||
| {this.state.testActionError.isError && <ActionErrorPopup onClose={this.resetTestActionError} message={this.state.testActionError.errorMessage} />} | |||
| {error && <ErrorDialog closeDialog={this.onCloseErrorDialog} showMessage={error} />} | |||
There was a problem hiding this comment.
as you can see we already have a component for error.
also you can use the variable error that already exist.
example:
const error = your error || errorOnDeleteTest ;
There was a problem hiding this comment.
@manorlh make sense. done!
ui/src/features/get-tests.js
Outdated
| testActionError: { | ||
| isError: false, | ||
| errorMessage: EMPTY_STRING, | ||
| }, |
There was a problem hiding this comment.
it will be nicer to use one variable for that - something like renderTestError
and its value would be the error text if error accrued and undefined/null if it didn't.
ui/src/features/get-tests.js
Outdated
| @@ -118,13 +128,36 @@ class getTests extends React.Component { | |||
| this.setState({ openViewTest: data }); | |||
| }; | |||
|
|
|||
| updateTestActionError = ({ isError, errorMessage }) => { | |||
| this.setState({ | |||
| ...this.state, | |||
There was a problem hiding this comment.
this.setState update only the keys that you send, so you don't need "...this.state "
|
thank you for your contribution! it's awesome:) |
|
thanks. 🙏 I will review it again tomorrow |
Issue:
Invalid test data created thro API when rendered on UI crashes
Fix:
IMPORTANT: Error handling done for both "EDIT" and "CLONE"
Show error pop up if test data is invalid
Related issues: #498
Have extracted constants for error messages, titles, etc
Created isValidTest function that reuses existing "createStateForEditTest" function. [Creating new function would require refactoring existing flows, which we may do separately]
Created ActionErrorComponent for showing error that can be used for showing any error in Test Actions