Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress Bar Non-visual alternative #721

Open
OlenaKashuba opened this issue Jul 15, 2021 · 1 comment
Open

Progress Bar Non-visual alternative #721

OlenaKashuba opened this issue Jul 15, 2021 · 1 comment
Assignees
Labels
accessibility This issue affects accessibility needs refinement The issue needs more discussion is not ready to start work on it released

Comments

@OlenaKashuba
Copy link
Contributor

OlenaKashuba commented Jul 15, 2021

We might want to improve experience of customers who use screen-reader via providing screen-reader only text alternative to visual representation of progress bar.

Suggestion: add paragraph with visually-hidden text e.g. <p> Step 2 of 4 </p>.

Note: we might not want to make the progress bar focusable because it is not interactive, so the visually hidden text we add will be only announced when user reads whole page via "Control + option + A"

@OlenaKashuba OlenaKashuba added the accessibility This issue affects accessibility label Jul 15, 2021
@Gabss405 Gabss405 self-assigned this Aug 26, 2021
Gabss405 added a commit that referenced this issue Aug 26, 2021
added aria-label if withStep is false

fix #721
@Gabss405 Gabss405 mentioned this issue Aug 26, 2021
3 tasks
Gabss405 added a commit that referenced this issue Aug 26, 2021
Gabss405 added a commit that referenced this issue Aug 31, 2021
added aria role of progress bar for better compatibility across browsers

#721
Gabss405 added a commit that referenced this issue Aug 31, 2021
Gabss405 added a commit that referenced this issue Sep 2, 2021
poteirard pushed a commit that referenced this issue Sep 7, 2021
### [4.45.1](v4.45.0...v4.45.1) (2021-09-07)

### Bug Fixes

* **progress:** non visual alternative ([8b03370](8b03370)), closes [#721](#721)
* **progress:** non visual alternative to step text ([2eea70b](2eea70b)), closes [#721](#721)
* **progress bar:** non visual alternative ([aa0bc38](aa0bc38)), closes [#721](#721)
* **progress bar:** removed aria role ([2ccb326](2ccb326)), closes [#721](#721)
* **progress bar:** rewrote snapshots ([16c24f5](16c24f5)), closes [#721](#721)
* **progress-bar:** non visual alternative ([4dc5142](4dc5142)), closes [#721](#721)
@poteirard
Copy link
Contributor

🎉 This issue has been resolved in version 4.45.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Gabss405 Gabss405 reopened this Oct 6, 2021
@Gabss405 Gabss405 added the needs refinement The issue needs more discussion is not ready to start work on it label Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility This issue affects accessibility needs refinement The issue needs more discussion is not ready to start work on it released
Projects
None yet
Development

No branches or pull requests

3 participants