Progress bar a11y #733
Merged
Progress bar a11y #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gabss405
requested review from
admmasters,
katebeavis,
moshie,
poteirard,
raff-r and
steedems
as code owners
|
✔️ Deploy Preview for zrc ready! 🔨 Explore the source changes: a7a9469 🔍 Inspect the deploy log: https://app.netlify.com/sites/zrc/deploys/61374c5b9b260d0007de6ff9 😎 Browse the preview: https://deploy-preview-733--zrc.netlify.app/ |
added new snaps #721
added aria role of progress bar for better compatibility across browsers #721
Gabss405
added
accessibility
poteirard
approved these changes
Sep 7, 2021
|
🎉 This PR is included in version 4.45.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#721
Not sure if setting tabIndex to -1 is absolutely necessary?- progress bar isn't focusable anyway, removedit works in Chrome,Safari & Edge, Firefox
Firefox: screenreader gets stuck on progressbar if withStep is true (user can tab to skip)removing role fixed thisadded role="progressbar" for better compatibilityhaving spoken to @OlenaKashuba this is an overkill, also introduces the bug in FirefoxScreen.Recording.2021-08-26.at.15.29.49.mov
Screen.Recording.2021-08-26.at.15.19.31.mov