New <Tooltip /> component 🧪 #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New <Tooltip /> component which in turn is just a wrapper over `@tippy.js/react` with some styling constraints applied.
ubbe-xyz
requested review from
AntonyKwok,
JuliaHempel,
poteirard,
steedems and
thegrinder
as code owners
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
==========================================
+ Coverage 92.35% 92.38% +0.02%
==========================================
Files 69 70 +1
Lines 628 630 +2
Branches 166 166
==========================================
+ Hits 580 582 +2
Misses 48 48
Continue to review full report at Codecov.
|
ubbe-xyz
commented
Jan 14, 2020
| import { render } from '@testing-library/react'; | ||
| import Tooltip from './Tooltip'; | ||
|
|
||
| describe('<Tooltip />', () => { |
There was a problem hiding this comment.
I didn't think necessary to add more tests, given we're just wrapping a library that is quite well tested already 👍🏻
poteirard
approved these changes
Jan 14, 2020
thegrinder
approved these changes
Jan 14, 2020
Merged
|
🎉 This PR is included in version 2.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
New
<Tooltip />component which in turns is just a wrapper over@tippy.js/reactwith design constraints applied on top.Bundle cost
Tippy JS handles already a lot of the edge-cases associated to tooltips for us ( 👀 "Adaptability" section below ) and make sure they stay as accessible as possible.
This comes with an import cost though ☝🏻 ( what do you think @poteirard ? ) but at least we think is safer and more performant than any custom solution we could engineer...
Adaptability
1. Hover
2. Touch
3. Fit on scroll
( 👀 notice how the tooltip vertical alignment changes... )
4. Fit on viewport edge
( 👀 notice how the tooltip horizontal alignment changes... )