Hitting enter on a link triggers previousSlide #82
Comments
jaylandro
changed the title
previousSlide
jaylandro
changed the title
jaylandro
added a commit
to jaylandro/eagle.js
that referenced
this issue
May 20, 2019
This is a proposed fix for a click event being emitted by keyboard navigation on a link. Issue described below Zulko#82 (comment)
jaylandro
added a commit
to jaylandro/eagle.js
that referenced
this issue
May 20, 2019
jaylandro
added a commit
to jaylandro/eagle.js
that referenced
this issue
May 20, 2019
… was on the left or right hand of the screen. Changed the logic to check for href of target Zulko#82
yaodingyd
pushed a commit
that referenced
this issue
May 20, 2019
* Check if click event came from keyboard #82 This is a proposed fix for a click event being emitted by keyboard navigation on a link. Issue described below #82 (comment) * Linting fixes for Travis CS Issue #82 * Realized this could happen on a regular click event as well if a link was on the left or right hand of the screen. Changed the logic to check for href of target #82 * Started running lint locall,y apologies for all the commits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When navigating though slides, if a user tries to keyboard
tabto a link on one of the slides and use theenterkey to navigate to the link (standard browser keyboard navigation) Eagle.js loads previous slide.This is due to the fact that the browser emits a click event when hitting enter on an
Anchorhref link. This is caught by the click right side/click left side logic.Checking to see if there are screenX and screenY coordinates catches this.
Reproducible bug Code Sandbox here:
https://codesandbox.io/embed/eaglejs-template-1sqlf
PR coming shortly
The text was updated successfully, but these errors were encountered: