Skip to content

Commit

Permalink
fixed ffmpeg error reporting on Python 3
Browse files Browse the repository at this point in the history
I got the following error:

    /usr/local/lib/python3.5/dist-packages/moviepy/audio/io/ffmpeg_audiowriter.py:91: in write_frames
        + "\n\n"+ffmpeg_error))
    E   TypeError: Can't convert 'bytes' object to str implicitly

To fix it, I wrapped `ffmpeg_error` in `str()` in `ffmpeg_audiowriter.py`.  I also did the same in `ffmpeg_writer.py` but I didn't test the latter.
  • Loading branch information
narfdotpl committed May 16, 2017
1 parent f63a985 commit 6a9af8c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion moviepy/audio/io/ffmpeg_audiowriter.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def write_frames(self,frames_array):
ffmpeg_error = self.proc.stderr.read()
error = (str(err)+ ("\n\nMoviePy error: FFMPEG encountered "
"the following error while writing file %s:"%self.filename
+ "\n\n"+ffmpeg_error))
+ "\n\n" + str(ffmpeg_error)))

if b"Unknown encoder" in ffmpeg_error:

Expand Down
2 changes: 1 addition & 1 deletion moviepy/video/io/ffmpeg_writer.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ def write_frame(self, img_array):
_, ffmpeg_error = self.proc.communicate()
error = (str(err) + ("\n\nMoviePy error: FFMPEG encountered "
"the following error while writing file %s:"
"\n\n %s" % (self.filename, ffmpeg_error)))
"\n\n %s" % (self.filename, str(ffmpeg_error))))

if b"Unknown encoder" in ffmpeg_error:

Expand Down

0 comments on commit 6a9af8c

Please sign in to comment.