Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get ffmpeg to use all audio streams #1008

Merged
merged 1 commit into from Mar 17, 2020
Merged

Get ffmpeg to use all audio streams #1008

merged 1 commit into from Mar 17, 2020

Conversation

vmaliaev
Copy link
Contributor

@vmaliaev vmaliaev commented Sep 9, 2019

For some formats ffmpeg picks just one audio stream without "-map 0" instead of all.

  • If this is a bugfix, I have provided code that clearly demonstrates the problem and that works when used with this PR
  • I have added a test to the test suite, if necessary
  • I have properly documented new or changed features in the documention, or the docstrings
  • I have properly documented unusual changes to the code in the comments around it
  • I have made note of any breaking/backwards incompatible changes

@vmaliaev
Update ffmpeg_tools.py
250bdf8 
For some formats ffmpeg picks just one audio stream without "-map 0" instead of all.
@tburrows13 tburrows13 changed the title Update ffmpeg_tools.py Get ffmpeg to use al audio streams Mar 10, 2020
@tburrows13 tburrows13 added bug-fix For PRs and issues solving bugs. lib-FFmpeg Issues pertaining to dependency FFmpeg. labels Mar 10, 2020
@tburrows13 tburrows13 changed the title Get ffmpeg to use al audio streams Get ffmpeg to use all audio streams Mar 10, 2020
@tburrows13
Copy link
Collaborator

It would be nice to have an example of a file that this can be demonstrated on, but I'll merge it anyway as it looks to be correct.

@tburrows13 tburrows13 merged commit c901e1a into Zulko:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgaitan mgaitan mgaitan approved these changes

Assignees
No one assigned
Labels
bug-fix For PRs and issues solving bugs. lib-FFmpeg Issues pertaining to dependency FFmpeg.
Projects
None yet
Milestone
Release v1.0.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vmaliaev @tburrows13 @mgaitan