PEP8 : ffmpeg_reader

[tacaswell]

No description provided.

[Zulko]

Ach, I am working on this file right now... Plus, I agree with the spacing correction, but for the rest, lines such as

self.depth = 4 if pix_fmt=="rgba" else 3

are perfectly valid in my opinion, I don't think they need to be exploded into 4 lines. And I found a typo in your new lines: pix_ftm instead of pix_fmt.

So I am not merging this one, sorry, but thanks ! PEP8 is indead a problem in the current state of the code.

[tacaswell]

fixed the typo.

I find the explicit if statements are much more readable and can not think of any cost to having more lines of code.

[Zulko]

Still not convinced by the conditional if, but the PEP8 corrections are worth the merge. Thanks !

[tacaswell]

Its a bit late now that you have already pushed the button, but for future reference, if you pull my branch down to your local machine and then do an interactive merge. You could revert the changes you don't like in the merge commit and then push the merge commit back up to the github master. Because my commit would be in the history (as you changed the code in the merge commit) github will auto-magically close the PR and you don't get the changes you don't want.

It will also take you less time than it took me to write this comment to just revert it with a new commit ;)

[Zulko]

Ok, thanks for the tip !

Le 04/02/2014 17:57, Thomas A Caswell a écrit :

Its a bit late now that you have already pushed the button, but for
future reference, if you pull my branch down to your local machine and
then do an interactive merge. You could revert the changes you don't
like in the merge commit and then push the merge commit back up to the
github master. Because my commit would be in the history (as you
changed the code in the merge commit) so github will auto-magically
close the PR and you don't get the changes you don't want.

It will also take you less time than it took me to write this comment
to just revert it with a new commit ;)

—
Reply to this email directly or view it on GitHub
#11 (comment).

[Zulko]

Hey !

In case you are interested, I changed a few lines in ffmpeg_reader to
make it python3-compatible.
On python3 subprocess has a small buffer by default which makes it
impossible to read a frame from a video.

See the changes here:

252f175#diff-a49583100a493b6fe1c05b48824e4a3c

Le 04/02/2014 17:57, Thomas A Caswell a écrit :

Its a bit late now that you have already pushed the button, but for
future reference, if you pull my branch down to your local machine and
then do an interactive merge. You could revert the changes you don't
like in the merge commit and then push the merge commit back up to the
github master. Because my commit would be in the history (as you
changed the code in the merge commit) so github will auto-magically
close the PR and you don't get the changes you don't want.

It will also take you less time than it took me to write this comment
to just revert it with a new commit ;)

—
Reply to this email directly or view it on GitHub
#11 (comment).