-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flake8 formatting cleanup #1151
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tburrows13
added
the
refactor
Does not affect the end user at all i.e. making code easier to read or PEP8 compliant.
label
Apr 17, 2020
tburrows13
commented
Apr 17, 2020
I'm ready for this to be merged as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
refactor
Does not affect the end user at all i.e. making code easier to read or PEP8 compliant.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing of any substance is supposed to have changed in this PR. I've simply gone through all the flake8 warnings and corrected the code where necessary, or specifically ignored that type of error where it conflicts with black.
Most notable changes:
All raw
except:
have been replaced withexcept Exception:
All assigned lambdas have been replaced with a
def
The Travis build will now fail when flake8 detects undefined variable names. (Removal of
--exit-zero
on the important check)All regex strings with backslashes have been made 'raw' by putting an
r
at the start of the string. This prevents aDeprecationWarning
.