Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake8 formatting cleanup #1151

Merged
merged 11 commits into from
Apr 24, 2020
Merged

Flake8 formatting cleanup #1151

merged 11 commits into from
Apr 24, 2020

Conversation

tburrows13
Copy link
Collaborator

@tburrows13 tburrows13 commented Apr 17, 2020

Nothing of any substance is supposed to have changed in this PR. I've simply gone through all the flake8 warnings and corrected the code where necessary, or specifically ignored that type of error where it conflicts with black.

Most notable changes:
All raw except: have been replaced with except Exception:
All assigned lambdas have been replaced with a def
The Travis build will now fail when flake8 detects undefined variable names. (Removal of --exit-zero on the important check)
All regex strings with backslashes have been made 'raw' by putting an r at the start of the string. This prevents a DeprecationWarning.

@tburrows13 tburrows13 added the refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant. label Apr 17, 2020
@coveralls
Copy link

coveralls commented Apr 17, 2020

Coverage Status

Coverage decreased (-0.2%) to 64.786% when pulling 58c4c03 on tburrows13:fix-warnings into 24ebfdb on Zulko:master.

@tburrows13 tburrows13 added this to the Release v2.0.0 milestone Apr 18, 2020
@tburrows13
Copy link
Collaborator Author

I'm ready for this to be merged as well.

@tburrows13 tburrows13 merged commit 8d14ef9 into Zulko:master Apr 24, 2020
@tburrows13 tburrows13 deleted the fix-warnings branch April 24, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Does not affect the end user at all i.e. making code easier to read or PEP8 compliant.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants