Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add VideoClip.set_layer() #1176

Merged
merged 6 commits into from
May 10, 2020
Merged

Add VideoClip.set_layer() #1176

merged 6 commits into from
May 10, 2020

Conversation

tburrows13
Copy link
Collaborator

@tburrows13 tburrows13 commented May 3, 2020 •
edited
Loading

Closes #1162.

Allows custom ordering of clips in a CompositeVideoClip, instead of having to sort the list of clips that you create the CompositeVideoClip from.

  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it
  • I have formatted my code using black -t py36

@tburrows13 tburrows13 mentioned this pull request May 3, 2020
Closed
@coveralls
Copy link

coveralls commented May 3, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 67.395% when pulling 7061568 on tburrows13:add-set_layer into 3b25a76 on Zulko:master.

@tburrows13 tburrows13 added the feature New addition to the API i.e. a new class, method or parameter. label May 5, 2020
amirothman
amirothman approved these changes May 9, 2020
View reviewed changes
Copy link

@amirothman amirothman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. short and sweet

@tburrows13 tburrows13 merged commit 427c122 into Zulko:master May 10, 2020
@tburrows13 tburrows13 mentioned this pull request May 10, 2020
Open
4 tasks
@tburrows13 tburrows13 deleted the add-set_layer branch May 14, 2020 22:08
@tburrows13 tburrows13 mentioned this pull request Jan 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amirothman amirothman amirothman approved these changes

Assignees
No one assigned
Labels
feature New addition to the API i.e. a new class, method or parameter.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CompositeVideoClip - Different rules for clip appereance
3 participants
@tburrows13 @coveralls @amirothman