Fix fx.freeze frame indexing. Fix #1307. #1348
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #1307 by making the
fx.freeze
use the last timestamp instead of 1 second before the last timestamp.To prevent out-of-bounds errors, the default
make_frame
forBitmapClip
andDataVideoClip
have been updated to take the last frame in case the timestamp is greater than the length of the clip, as it makes the most sense for the timestamp equal to the duration of the clip to be the last frame, instead of 1 frame past the end of the clip.The test
test_freeze
has been updated to reflect this change, as it had previously assumed a conversion of timestamps to frames that was inconsistent. Basically, it went from assuming that the second frame was from 1≤t≤2, which is illogical, to 1≤t<2, which can be consistent across the entire clip.tests/
black -t py36