Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'freeze' FX not freezing at the end and add proper tests #1461

Merged
merged 6 commits into from
Jan 17, 2021
Merged

Fix 'freeze' FX not freezing at the end and add proper tests #1461

merged 6 commits into from
Jan 17, 2021

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented Jan 16, 2021 •
edited
Loading

Closes #1307, closes #1348.

  • The solution is just to freeze at clip.duration - padding_end - 1 fps.
  • Rewritten tests for freeze FX checking all arguments combinations.
  • I have formatted my code using black -t py36

@mondeja mondeja added video Related to VideoClip and related classes, or handling of video in general. fx Related to advanced effects applied via clip.fx(), or effects in general. bug-fix For PRs and issues solving bugs. labels Jan 16, 2021
@coveralls
Copy link

coveralls commented Jan 16, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 66.04% when pulling d233ac4 on mondeja:fix-1307 into 646674c on Zulko:master.

@mondeja mondeja changed the title Fixed 'freeze' FX not freezing at the end with 't=end' argument Fixed 'freeze' FX not freezing at the end with 't="end"' argument Jan 16, 2021
@mondeja mondeja mentioned this pull request Jan 16, 2021
Closed
5 tasks
@mondeja mondeja changed the title Fixed 'freeze' FX not freezing at the end with 't="end"' argument Fix 'freeze' FX not freezing at the end with 't="end"' argument Jan 16, 2021
@mondeja mondeja marked this pull request as draft January 17, 2021 12:32
@mondeja

This comment has been minimized.

Sign in to view
@mondeja mondeja marked this pull request as ready for review January 17, 2021 13:31
@mondeja mondeja changed the title Fix 'freeze' FX not freezing at the end with 't="end"' argument Fix 'freeze' FX not freezing at the end and fix tests Jan 17, 2021
@mondeja mondeja changed the title Fix 'freeze' FX not freezing at the end and fix tests Fix 'freeze' FX not freezing at the end and add proper tests Jan 17, 2021
@mondeja mondeja marked this pull request as draft January 17, 2021 14:47
@mondeja mondeja marked this pull request as ready for review January 17, 2021 14:53
@mondeja mondeja merged commit cea335a into Zulko:master Jan 17, 2021
tburrows13 pushed a commit to tburrows13/moviepy that referenced this pull request Jan 19, 2021
@mondeja @tburrows13
Fix 'freeze' FX not freezing at the end and add proper tests (Zulko#1461
0e70bbd 
)

* Fixed 'freeze' FX not freezing at the end with 't=end' argument

* Improve CHANGELOG entry

* Fix tests for 'freeze' FX and handle inconsistency of arguments

* Improve comments

* Add more test combinations

* Improve tests ids
@mondeja mondeja mentioned this pull request Jan 23, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix For PRs and issues solving bugs. fx Related to advanced effects applied via clip.fx(), or effects in general. video Related to VideoClip and related classes, or handling of video in general.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Freezing movie frame on last frame or end
2 participants
@mondeja @coveralls