Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'center', 'translate' and 'bg_color' arguments to 'rotate' FX #1474

Merged
merged 6 commits into from
Jan 22, 2021

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented Jan 20, 2021

  • Added support for arguments center, translate and bg_color (in PIL is named as fillcolor).
  • Add PIL version checking to make sure that arguments are supported by the PIL version of the user.
  • Fix documentation.
  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly documented new or changed features in the documentation or in the docstrings
  • I have properly explained unusual or unexpected code in the comments around it
  • I have formatted my code using black -t py36

@mondeja mondeja added video Related to VideoClip and related classes, or handling of video in general. feature New addition to the API i.e. a new class, method or parameter. fx Related to advanced effects applied via clip.fx(), or effects in general. labels Jan 20, 2021
@coveralls
Copy link

coveralls commented Jan 20, 2021

Coverage Status

Coverage increased (+0.04%) to 66.812% when pulling 41da302 on mondeja:better-rotate-fx into 8cc3eeb on Zulko:master.

@mondeja mondeja marked this pull request as draft January 20, 2021 16:46
@mondeja mondeja marked this pull request as ready for review January 20, 2021 16:50
@mondeja
Copy link
Collaborator Author

mondeja commented Jan 20, 2021

I'm not sure if bg_color is the name that would use moviepy. What do you think @tburrows13?

@tburrows13
Copy link
Collaborator

Just fyi for when you are updating docstrings bear in mind that we are using numpydoc (https://numpydoc.readthedocs.io/en/latest/format.html#sections), and in my doc improvements PR (#1438) I'm adding things like optional and argument type (as in numpydoc standards) to the parameter documentation. Feel free to do the same when you are adding new documented parameters.

bg_color is what is used elsewhere in moviepy so you should use that for now. I didn't change it in #1170, but maybe it should be changed in the future, but if that happens, we can easily change this one along with the rest.

@mondeja mondeja marked this pull request as draft January 22, 2021 11:31
@mondeja mondeja marked this pull request as ready for review January 22, 2021 11:47
@mondeja mondeja merged commit 143618c into Zulko:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New addition to the API i.e. a new class, method or parameter. fx Related to advanced effects applied via clip.fx(), or effects in general. video Related to VideoClip and related classes, or handling of video in general.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants