Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix https://github.com/Zulko/moviepy/issues/1994 #1995

Merged
merged 1 commit into from Jul 11, 2023
Merged

Fix https://github.com/Zulko/moviepy/issues/1994 #1995

merged 1 commit into from Jul 11, 2023

Conversation

tobiasBora
Copy link
Contributor

@tobiasBora tobiasBora commented Jun 21, 2023 •
edited

Fix #1994

  • I have provided code that clearly demonstrates the bug and that only works correctly when applying this fix
  • I have added suitable tests demonstrating a fixed bug or new/changed feature to the test suite in tests/
  • I have properly explained unusual or unexpected code in the comments around it

@tobiasBora tobiasBora mentioned this pull request Jun 21, 2023
Closed
@coveralls
Copy link

Coverage Status

coverage: 84.423% (-0.3%) from 84.697% when pulling 1b6ce52 on tobiasBora:fix_del_close into b5bb086 on Zulko:master.

@coveralls
Copy link

coveralls commented Jun 21, 2023 •
edited

Coverage Status

coverage: 88.418% (+3.7%) from 84.697% when pulling 1b6ce52 on tobiasBora:fix_del_close into b5bb086 on Zulko:master.

@coveralls
Copy link

Coverage Status

coverage: 89.077% (+4.4%) from 84.697% when pulling 1b6ce52 on tobiasBora:fix_del_close into b5bb086 on Zulko:master.

@keikoro keikoro requested a review from mgaitan June 21, 2023 14:20
OsaAjani pushed a commit to OsaAjani/moviepy that referenced this pull request Jun 25, 2023
Apply PR Zulko#1995 fixing issue Zulko#1994
a7295a7
@tburrows13 tburrows13 merged commit bc8d1a8 into Zulko:master Jul 11, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgaitan mgaitan Awaiting requested review from mgaitan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError: 'NoneType' object has no attribute 'stdout'
3 participants
@tobiasBora @coveralls @tburrows13