Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix https://github.com/Zulko/moviepy/issues/1994 #1995

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Fix https://github.com/Zulko/moviepy/issues/1994 #1995

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion moviepy/Clip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,10 @@ def __getitem__(self, key):
return self.get_frame(key)

def __del__(self):
self.close()
# WARNING: as stated in close() above, if we call close, it closes clips even
# if shallow copies are still in used, leading to some bugs: https://github.com/Zulko/moviepy/issues/1994
# so don't call self.close() here, rather do it manually in the code.
pass

def __add__(self, other):
# concatenate. implemented in specialized classes
Expand Down