Windows Python3 incomatability fix in np reshape expecting float #386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #279 and #376, two users had issues in Python3 on Windows reading audio. Looks like this is due to np reshape expecting an int but getting a float, due to python 3 not "flooring" float division with a single
/
operator.I had the same error and fixed it by changing the operator to
//
. Some minor testing suggests the fix works and I don't immediately see any downstream issues from this change.