move PY3 to new compat.py file #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good job! Shouldn't the files change in #403 be updated as part of this PR? Also, just a small thing: should we maybe check for python 2 instead of 3? Just that when python 4 comes out (which probably will still be backwards compatible with 3), all these checks will need to be updated. I know that that is looking really far into the future, but it seems that we might as well put this in now...? |
|
Yes, that is something we need to think about. Also, how long do we plan on supporting python 2? |
ghost
merged commit 
|
@Earney: please leave some time before a PR and a merge ! This one changes the API and should therefore be discussed more. |
|
okay.. will do.
…On Wed, Feb 15, 2017 at 1:15 PM, Zulko ***@***.***> wrote:
@Earney <https://github.com/earney>: please leave some time before a PR
and a merge ! This one changes the API and should therefore be discussed
more.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#411 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABGu8rbvr0joSLY-2gGEFfccxufmHhoLks5rc07pgaJpZM4MCD0x>
.
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.