Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix YouTube embeds in docs #446

Merged
merged 1 commit into from
Mar 3, 2017
Merged

fix YouTube embeds in docs #446

merged 1 commit into from
Mar 3, 2017

Conversation

keikoro
Copy link
Collaborator

@keikoro keikoro commented Feb 24, 2017

Fixes #304, renders #342 + #343 invalid.

@keikoro keikoro changed the title fix YT embeds: AS3 objects -> iframes, http -> https fix YouTube embeds in docs Feb 24, 2017
@keikoro
Copy link
Collaborator Author

keikoro commented Feb 24, 2017

Replaces AS3 objects with iframes and gets rid of mixed content (http urls in https site).

@Zulko
Copy link
Owner

Zulko commented Feb 24, 2017

I'm not sure I understand what the problem is, the videos in the gallery work fine for me in Firefox and Chrome, is there a problem on some other browsers ? Are iframes the standard way of embedding youtube videos ?

@keikoro
Copy link
Collaborator Author

keikoro commented Feb 24, 2017

For me, the videos don't show in either browser + when opening the local versions of the files, I'm additionally experiencing the problem described by @COLABORATI in #304 (I'm prompted to download the files).

From the YouTube docs:

March 9, 2015

  • The document has been updated to reflect the fact that YouTube <object> embeds, the YouTube Flash Player API and the YouTube JavaScript Player API have all been deprecated as of January 27, 2015. A deprecation warning appears in several sections of this document to help point readers to the IFrame Player API as an alternative.

@keikoro
Copy link
Collaborator Author

keikoro commented Feb 24, 2017

From Chrome's console:
Mixed Content: The page at 'https://zulko.github.io/moviepy/gallery.html' was loaded over HTTPS, but requested an insecure resource 'http://youtube.com/v/zJtWPFX2bA0?rel=0'. This request has been blocked; the content must be served over HTTPS.

I'm also getting warnings for images, but apparently browsers aren't as strict about those, so they still show up.

@keikoro
Copy link
Collaborator Author

keikoro commented Feb 24, 2017

I have no idea why the videos show for you, @Zulko, because they really shouldn't. Perhaps different security settings? Maybe you allowed mixed content for your docs at some point (if that is even an option)?

@keikoro
Copy link
Collaborator Author

keikoro commented Feb 24, 2017

When I try to access the http version of the docs, I'm actually also getting the download prompts (except Chrome doesn't just display the Download dialogue but pops up this message).

screen shot 2017-02-24 at 10 38 20

@keikoro
Copy link
Collaborator Author

keikoro commented Feb 24, 2017

(My browsers default to the secure version of the docs pages... as they should.)

@keikoro
Copy link
Collaborator Author

keikoro commented Feb 24, 2017

I'm also getting the download prompts on mobile. Have you tried opening the docs with a browser you haven't used for development? (I'm not sure if/how being logged in could additionally affect this.)

@keikoro
Copy link
Collaborator Author

keikoro commented Mar 3, 2017

Just leaving a note here that @Zulko approved this PR on Gitter.

@ghost
Copy link

ghost commented Mar 3, 2017

Awesome!.. Lets merge this puppy then! :)

@keikoro keikoro merged commit 1fb79c1 into Zulko:master Mar 3, 2017
@keikoro keikoro deleted the fix_yt_objects branch March 12, 2017 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants