Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added doc for working with matplotlib #465

Merged
merged 2 commits into from
Apr 5, 2017
Merged

added doc for working with matplotlib #465

merged 2 commits into from
Apr 5, 2017

Conversation

flothesof
Copy link
Contributor

Hi guys,

here's a pull request integrating the original matplotlib example from Zulko's blog post into the documentation.

Best regards,
Florian

@flothesof flothesof mentioned this pull request Mar 5, 2017
Closed
@coveralls
Copy link

coveralls commented Mar 5, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 37.306% when pulling e016e9e on flothesof:add-matplotlib-examples into fe742ad on Zulko:master.

@flothesof
Copy link
Contributor Author

Hi @kerstin

(related to #421)
Would you be so kind to review this pull request that features what was discussed in the issue?
Also, did you manage to fix the error problems that appear when building the docs you were mentioning?
(I noticed the current documentation for moviepy was last pushed in Dec. 2014, gh-pages branch)

Best,
Florian

@mbeacom mbeacom added the LGTM Passed inspection by maintainers. label Apr 5, 2017
@mbeacom mbeacom added this to the Release v0.2.3.2 milestone Apr 5, 2017
@mbeacom
Copy link
Collaborator

mbeacom commented Apr 5, 2017

@Zulko @Earney Thoughts on this documentation addition?

@ghost
Copy link

ghost commented Apr 5, 2017

I borrowed one of these examples for the tests. Seemed to work like a charm! I haven't tried the others to make sure they work, but I don't see anything alarming.

@Zulko
Copy link
Owner

Zulko commented Apr 5, 2017

Looks good to me

@coveralls
Copy link

Coverage Status

Coverage remained the same at 50.16% when pulling 852bb04 on flothesof:add-matplotlib-examples into 5eda6c0 on Zulko:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 50.16% when pulling 852bb04 on flothesof:add-matplotlib-examples into 5eda6c0 on Zulko:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 50.16% when pulling 852bb04 on flothesof:add-matplotlib-examples into 5eda6c0 on Zulko:master.

@coveralls
Copy link

coveralls commented Apr 5, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 50.16% when pulling 852bb04 on flothesof:add-matplotlib-examples into 5eda6c0 on Zulko:master.

@mbeacom mbeacom merged commit 2648a86 into Zulko:master Apr 5, 2017
@mbeacom mbeacom added the documentation Related to documentation in official project docs or individual docstrings. label Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbeacom mbeacom mbeacom approved these changes

Assignees
No one assigned
Labels
documentation Related to documentation in official project docs or individual docstrings. LGTM Passed inspection by maintainers.
Projects
None yet
Milestone
Release v0.2.3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@flothesof @coveralls @mbeacom @Zulko